[Konversation-devel] Review Request: Support for Audacious2 in Konversation.

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1583/#review2321
-----------------------------------------------------------


I don't like the duplication of the code for old Audacious and Audacious 2. This should make use of inheritance, i.e. there should be an AudaciousPlayer parent class and two subclasses that only set different tools to be called.

- Eike


On 2009-09-12 10:59:23, Morten Badensoe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1583/
> -----------------------------------------------------------
> 
> (Updated 2009-09-12 10:59:23)
> 
> 
> Review request for konversation.
> 
> 
> Summary
> -------
> 
> This patch add support for Audacious2 in the Konversation (now playing) media script - and keeps the support for Audacious.
> 
> 
> Diffs
> -----
> 
>   trunk/extragear/network/konversation/data/scripts/media 1022659 
> 
> Diff: http://reviewboard.kde.org/r/1583/diff
> 
> 
> Testing
> -------
> 
> Testing done using KDE 4.3.1, Konversation 1.2-alpha6 and Audacious 2.1.0.
> 
> 
> Thanks,
> 
> Morten
> 
>