[Konversation-devel] [Bug 126224] Respect "MODES=" in RPL_ISUPPORT

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=126224





--- Comment #3 from Eike Hein <hein kde org>  2009-05-15 17:05:09 ---
This look good. I'm going to remove the support for an unlimited MODES (i.e.
setModesCount(100)), however: A message operating on so many nicks would likely
go beyond the 512 byte buffer limit imposed on a single IRC message, and thus
get cut off and lose self-consistency.

Granted, this is a far-fetched scenario because there's probably no ircd out
there that sends MODES without a value, and people are unlikely to set a mode
on 100 people at once, but let's not be content with creating bugs we know
about.

IOW, a proper implementation of unlimited MODES would need to be aware of the
buffer limit and send only that much at once as can fit into a single IRC
message. However, this patch is useful without support for that, so I'm going
to merge a 3-or-what-the-server-tells-us version of it (shifting the blame to
the server if it's too high a value).

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.