<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">FYI, master from just an hour ago<div class=""> Regards,</div><div class=""> Kurt<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">Begin forwarded message:</div><br class="Apple-interchange-newline"><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">From: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><a href="mailto:scan-admin@coverity.com" class="">scan-admin@coverity.com</a><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Subject: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><b class="">New Defects reported by Coverity Scan for Konsole</b><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Date: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">July 12, 2022 at 11:21:53 AM EDT<br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">To: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><a href="mailto:kurt.hindenburg@gmail.com" class="">kurt.hindenburg@gmail.com</a><br class=""></span></div><br class=""><div class=""><div class="">Hi,<br class=""><br class="">Please find the latest report on new defect(s) introduced to Konsole found with Coverity Scan.<br class=""><br class="">3 new defect(s) introduced to Konsole found with Coverity Scan.<br class=""><br class=""><br class="">New defect(s) Reported-by: Coverity Scan<br class="">Showing 3 of 3 defect(s)<br class=""><br class=""><br class="">** CID 354635: Incorrect expression (IDENTICAL_BRANCHES)<br class="">/home/kurthindenburg/Devel/KDE/src/konsole/src/Vt102Emulation.cpp: 2150 in Konsole::Vt102Emulation::emulateUpDown(bool, Konsole::KeyboardTranslator::Entry, QByteArray &, int)()<br class=""><br class=""><br class="">________________________________________________________________________________________________________<br class="">*** CID 354635: Incorrect expression (IDENTICAL_BRANCHES)<br class="">/home/kurthindenburg/Devel/KDE/src/konsole/src/Vt102Emulation.cpp: 2150 in Konsole::Vt102Emulation::emulateUpDown(bool, Konsole::KeyboardTranslator::Entry, QByteArray &, int)()<br class="">2144 if ((lineProperties[1] & LINE_WRAPPED) == 0 || (lineProperties[2] & LINE_WRAPPED) == 0) {<br class="">2145 realX = qMin(cuX, LineLength(lineProperties[2]) + 1);<br class="">2146 num = LineLength(lineProperties[1]) - cuX + realX;<br class="">2147 }<br class="">2148 }<br class="">2149 if (toCol > -1) {<br class=""><blockquote type="cite" class=""><blockquote type="cite" class=""><blockquote type="cite" class=""> CID 354635: Incorrect expression (IDENTICAL_BRANCHES)<br class=""> The same code is executed regardless of whether "toCol < realX" is true, because the 'then' and 'else' branches are identical. Should one of the branches be modified, or the entire 'if' statement replaced?<br class=""></blockquote></blockquote></blockquote>2150 if (toCol < realX) {<br class="">2151 num += up ? realX - toCol : toCol - realX;<br class="">2152 } else {<br class="">2153 num += up ? realX - toCol : toCol - realX;<br class="">2154 }<br class="">2155 }<br class=""><br class="">** CID 354634: Resource leaks (DELETE_ARRAY)<br class="">/home/kurthindenburg/Devel/KDE/src/konsole/src/Screen.cpp: 1938 in Konsole::Screen::copyLineToStream(int, int, int, Konsole::TerminalCharacterDecoder *, bool, bool, QFlags<Konsole::Screen::DecodingOption>) const()<br class=""><br class=""><br class="">________________________________________________________________________________________________________<br class="">*** CID 354634: Resource leaks (DELETE_ARRAY)<br class="">/home/kurthindenburg/Devel/KDE/src/konsole/src/Screen.cpp: 1938 in Konsole::Screen::copyLineToStream(int, int, int, Konsole::TerminalCharacterDecoder *, bool, bool, QFlags<Konsole::Screen::DecodingOption>) const()<br class="">1932 }<br class="">1933 <br class="">1934 // decode line and write to text stream<br class="">1935 decoder->decodeLine(newBuffer, count, currentLineProperties);<br class="">1936 <br class="">1937 if (todel) {<br class=""><blockquote type="cite" class=""><blockquote type="cite" class=""><blockquote type="cite" class=""> CID 354634: Resource leaks (DELETE_ARRAY)<br class=""> Deleting array variable "newBuffer" with non-array "delete" in "delete newBuffer".<br class=""></blockquote></blockquote></blockquote>1938 delete newBuffer;<br class="">1939 }<br class="">1940 <br class="">1941 return count;<br class="">1942 }<br class="">1943 <br class=""><br class="">** CID 354633: (DEADCODE)<br class="">/home/kurthindenburg/Devel/KDE/src/konsole/src/Vt102Emulation.cpp: 879 in Konsole::Vt102Emulation::receiveChars(const QVector<unsigned int> &)()<br class="">/home/kurthindenburg/Devel/KDE/src/konsole/src/Vt102Emulation.cpp: 872 in Konsole::Vt102Emulation::receiveChars(const QVector<unsigned int> &)()<br class="">/home/kurthindenburg/Devel/KDE/src/konsole/src/Vt102Emulation.cpp: 898 in Konsole::Vt102Emulation::receiveChars(const QVector<unsigned int> &)()<br class=""><br class=""><br class="">________________________________________________________________________________________________________<br class="">*** CID 354633: (DEADCODE)<br class="">/home/kurthindenburg/Devel/KDE/src/konsole/src/Vt102Emulation.cpp: 879 in Konsole::Vt102Emulation::receiveChars(const QVector<unsigned int> &)()<br class="">873 } else if (cc == 0x7F) {<br class="">874 // ignore<br class="">875 }<br class="">876 break;<br class="">877 case DcsIgnore:<br class="">878 if (cc == 0x9C) {<br class=""><blockquote type="cite" class=""><blockquote type="cite" class=""><blockquote type="cite" class=""> CID 354633: (DEADCODE)<br class=""> Execution cannot reach this statement: "this->switchState(Konsole::...".<br class=""></blockquote></blockquote></blockquote>879 switchState(Ground, cc);<br class="">880 } else if (cc <= 0x7F) {<br class="">881 // ignore<br class="">882 }<br class="">883 break;<br class="">884 case OscString:<br class="">/home/kurthindenburg/Devel/KDE/src/konsole/src/Vt102Emulation.cpp: 872 in Konsole::Vt102Emulation::receiveChars(const QVector<unsigned int> &)()<br class="">866 }<br class="">867 break;<br class="">868 case DcsPassthrough:<br class="">869 if (cc <= 0x7E || cc >= 0xA0) { // 0x18, 0x1A, 0x1B already taken care of<br class="">870 put(cc);<br class="">871 } else if (cc == 0x9C) {<br class=""><blockquote type="cite" class=""><blockquote type="cite" class=""><blockquote type="cite" class=""> CID 354633: (DEADCODE)<br class=""> Execution cannot reach this statement: "this->switchState(Konsole::...".<br class=""></blockquote></blockquote></blockquote>872 switchState(Ground, cc);<br class="">873 } else if (cc == 0x7F) {<br class="">874 // ignore<br class="">875 }<br class="">876 break;<br class="">877 case DcsIgnore:<br class="">/home/kurthindenburg/Devel/KDE/src/konsole/src/Vt102Emulation.cpp: 898 in Konsole::Vt102Emulation::receiveChars(const QVector<unsigned int> &)()<br class="">892 }<br class="">893 break;<br class="">894 case SosPmApcString:<br class="">895 if (cc <= 0x7F || cc >= 0xA0) { // 0x18, 0x1A, 0x1B already taken care of.<br class="">896 apc_put(cc);<br class="">897 // ignore<br class=""><blockquote type="cite" class=""><blockquote type="cite" class=""><blockquote type="cite" class=""> CID 354633: (DEADCODE)<br class=""> Execution cannot reach this statement: "if (cc == 156U) {<br class=""></blockquote></blockquote></blockquote> this->s...".<br class="">898 } else if (cc == 0x9C) {<br class="">899 switchState(Ground, cc);<br class="">900 }<br class="">901 break;<br class="">902 default:<br class="">903 break;<br class=""><br class=""><br class=""></div></div></blockquote></div><br class=""></div></body></html>