<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><meta http-equiv="Content-Type" content="text/html; charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hello all,<div class=""> This build is from master as of this morning - last commit is <span style="font-family:monospace" class=""><span style="color:#b26818;background-color:#ffffff;" class="">0952e29f</span><span style="background-color: rgb(255, 255, 255);" class="">.</span></span></div><div class=""><font face="monospace" class=""><span style="background-color: rgb(255, 255, 255);" class=""><br class=""></span></font></div><div class=""><font face="monospace" class=""><span style="background-color: rgb(255, 255, 255);" class=""> Kurt</span></font></div><div class=""><font face="monospace" class=""><span style="background-color: rgb(255, 255, 255);" class=""><br class=""></span></font><div class=""><blockquote type="cite" class=""><div class="">Begin forwarded message:</div><br class="Apple-interchange-newline"><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">From: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><a href="mailto:scan-admin@coverity.com" class="">scan-admin@coverity.com</a><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Subject: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><b class="">New Defects reported by Coverity Scan for Konsole</b><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Date: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">March 4, 2022 at 12:16:48 PM EST<br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">To: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><a href="mailto:kurt.hindenburg@gmail.com" class="">kurt.hindenburg@gmail.com</a><br class=""></span></div><br class=""><div class="">Hi,<br class=""><br class="">Please find the latest report on new defect(s) introduced to Konsole found with Coverity Scan.<br class=""><br class="">4 new defect(s) introduced to Konsole found with Coverity Scan.<br class="">1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.<br class=""><br class="">New defect(s) Reported-by: Coverity Scan<br class="">Showing 4 of 4 defect(s)<br class=""><br class=""><br class="">** CID 350423: Error handling issues (CHECKED_RETURN)<br class="">/home/kurthindenburg/Devel/KDE/src/konsole/src/Vt102Emulation.cpp: 1407 in Konsole::Vt102Emulation::processGraphicsToken(int)()<br class=""><br class=""><br class="">________________________________________________________________________________________________________<br class="">*** CID 350423: Error handling issues (CHECKED_RETURN)<br class="">/home/kurthindenburg/Devel/KDE/src/konsole/src/Vt102Emulation.cpp: 1407 in Konsole::Vt102Emulation::processGraphicsToken(int)()<br class="">1401 stream.avail_in = imageData.size(); // size of input<br class="">1402 stream.next_in = (Bytef *)data; // input char array<br class="">1403 stream.avail_out = out->size(); // size of output<br class="">1404 stream.next_out = (Bytef *)out->constData(); // output char array<br class="">1405 <br class="">1406 ret = inflateInit(&stream);<br class=""><blockquote type="cite" class=""><blockquote type="cite" class=""><blockquote type="cite" class=""> CID 350423: Error handling issues (CHECKED_RETURN)<br class=""> Calling "inflate(&stream, 0)" without checking return value. This library function may fail and return an error code.<br class=""></blockquote></blockquote></blockquote>1407 inflate(&stream, Z_NO_FLUSH);<br class="">1408 inflateEnd(&stream);<br class="">1409 <br class="">1410 if (keys['f'] != 24 && keys['f'] != 32) {<br class="">1411 imageData.clear();<br class="">1412 imageData.append(*out);<br class=""><br class="">** CID 350422: Resource leaks (RESOURCE_LEAK)<br class="">/home/kurthindenburg/Devel/KDE/src/konsole/src/Vt102Emulation.cpp: 1415 in Konsole::Vt102Emulation::processGraphicsToken(int)()<br class=""><br class=""><br class="">________________________________________________________________________________________________________<br class="">*** CID 350422: Resource leaks (RESOURCE_LEAK)<br class="">/home/kurthindenburg/Devel/KDE/src/konsole/src/Vt102Emulation.cpp: 1415 in Konsole::Vt102Emulation::processGraphicsToken(int)()<br class="">1409 <br class="">1410 if (keys['f'] != 24 && keys['f'] != 32) {<br class="">1411 imageData.clear();<br class="">1412 imageData.append(*out);<br class="">1413 }<br class="">1414 } else {<br class=""><blockquote type="cite" class=""><blockquote type="cite" class=""><blockquote type="cite" class=""> CID 350422: Resource leaks (RESOURCE_LEAK)<br class=""> Overwriting "out" in "out = NULL" leaks the storage that "out" points to.<br class=""></blockquote></blockquote></blockquote>1415 out = nullptr;<br class="">1416 }<br class="">1417 if (keys['f'] == 24 || keys['f'] == 32) {<br class="">1418 enum QImage::Format format = keys['f'] == 24 ? QImage::Format_RGB888 : QImage::Format_RGBA8888;<br class="">1419 if (!out) {<br class="">1420 out = new QByteArray(imageData.constData(), imageData.size());<br class=""><br class="">** CID 350421: Uninitialized variables (UNINIT)<br class="">/home/kurthindenburg/Devel/KDE/src/konsole/src/Vt102Emulation.cpp: 1407 in Konsole::Vt102Emulation::processGraphicsToken(int)()<br class=""><br class=""><br class="">________________________________________________________________________________________________________<br class="">*** CID 350421: Uninitialized variables (UNINIT)<br class="">/home/kurthindenburg/Devel/KDE/src/konsole/src/Vt102Emulation.cpp: 1407 in Konsole::Vt102Emulation::processGraphicsToken(int)()<br class="">1401 stream.avail_in = imageData.size(); // size of input<br class="">1402 stream.next_in = (Bytef *)data; // input char array<br class="">1403 stream.avail_out = out->size(); // size of output<br class="">1404 stream.next_out = (Bytef *)out->constData(); // output char array<br class="">1405 <br class="">1406 ret = inflateInit(&stream);<br class=""><blockquote type="cite" class=""><blockquote type="cite" class=""><blockquote type="cite" class=""> CID 350421: Uninitialized variables (UNINIT)<br class=""> Using uninitialized value "stream.total_out" when calling "inflate".<br class=""></blockquote></blockquote></blockquote>1407 inflate(&stream, Z_NO_FLUSH);<br class="">1408 inflateEnd(&stream);<br class="">1409 <br class="">1410 if (keys['f'] != 24 && keys['f'] != 32) {<br class="">1411 imageData.clear();<br class="">1412 imageData.append(*out);<br class=""><br class="">** CID 350420: API usage errors (INVALIDATE_ITERATOR)<br class="">/home/kurthindenburg/Devel/KDE/src/konsole/src/Screen.cpp: 1984 in Konsole::Screen::delPlacements(int, long long, long long, int, int, int)()<br class=""><br class=""><br class="">________________________________________________________________________________________________________<br class="">*** CID 350420: API usage errors (INVALIDATE_ITERATOR)<br class="">/home/kurthindenburg/Devel/KDE/src/konsole/src/Screen.cpp: 1984 in Konsole::Screen::delPlacements(int, long long, long long, int, int, int)()<br class="">1978 }<br class="">1979 <br class="">1980 void Screen::delPlacements(int del, qint64 id, qint64 pid, int x, int y, int z)<br class="">1981 {<br class="">1982 std::vector<std::unique_ptr<TerminalGraphicsPlacement_t>>::iterator i;<br class="">1983 i = _graphicsPlacements.begin();<br class=""><blockquote type="cite" class=""><blockquote type="cite" class=""><blockquote type="cite" class=""> CID 350420: API usage errors (INVALIDATE_ITERATOR)<br class=""> Using invalid iterator "i".<br class=""></blockquote></blockquote></blockquote>1984 while (i != _graphicsPlacements.end()) {<br class="">1985 TerminalGraphicsPlacement_t *placement = i->get();<br class="">1986 bool remove = false;<br class="">1987 switch (del) {<br class="">1988 case 1:<br class="">1989 remove = true;<br class=""><br class=""><br class=""></div></blockquote></div></div></div></body></html>