<table><tr><td style="">yrlf created this revision.<br />Herald added a project: Konsole.<br />Herald added a subscriber: konsole-devel.<br />yrlf requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27110">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>(patch originally submitted to the bug tracker on this bug: <a href="https://bugs.kde.org/show_bug.cgi?id=415508" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=415508</a>)</p>
<p>Sometimes the scrollbar reappears on the left side of the screen even when the scrollbar is set to 'hidden'.<br />
This happens when scrolling twice using the touchpad.</p>
<p>Qt 5.14 changed some parts of the <tt style="background: #ebebeb; font-size: 13px;">QScrollBar::wheelEvent(QWheelEvent*)</tt> function, which now sometimes calls <tt style="background: #ebebeb; font-size: 13px;">QScrollBarPrivate::setTransient(false)</tt>, which calls <tt style="background: #ebebeb; font-size: 13px;">QWidget::show()</tt>, which calls <tt style="background: #ebebeb; font-size: 13px;">QWidget::setVisible(true)</tt>.</p>
<p>This change works around this new behaviour that results in the QScrollBar not staying hidden when events are propagated to it by setting it to hidden again after each event propagated to the scroll bar.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>I tested it on ArchLinux using Sway, with Qt versions 5.13.2, 5.14.0, and 5.14.1, and it seems to work.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27110">https://phabricator.kde.org/D27110</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/TerminalDisplay.cpp<br />
src/TerminalDisplay.h</div></div></div><br /><div><strong>To: </strong>yrlf<br /><strong>Cc: </strong>konsole-devel, cent, EspadaV8, fbampaloukas, thsurrel, ngraham, maximilianocuria, hindenburg<br /></div>