<div dir="ltr"><div>C++17 is supported since GCC 7.1 and Clang 5. I guess all supported systems/distributions use compilers newer than 2+ years older than Konsole version they provide.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Dec 27, 2019 at 5:01 AM <<a href="mailto:kurt.hindenburg@gmail.com" target="_blank">kurt.hindenburg@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p>Does anyone have an opinion if we should require c++14 or c++17?
14 seems reasonable but sure about 17.<br>
</p>
<p><br>
</p>
<p>Kurt<br>
</p>
<div><br>
<br>
-------- Forwarded Message --------
<table cellspacing="0" cellpadding="0" border="0">
<tbody>
<tr>
<th valign="BASELINE" nowrap align="RIGHT">Subject:
</th>
<td>Re: Konsole | Simplify filters (!59)</td>
</tr>
<tr>
<th valign="BASELINE" nowrap align="RIGHT">Date: </th>
<td>Sun, 22 Dec 2019 21:09:26 +0000</td>
</tr>
<tr>
<th valign="BASELINE" nowrap align="RIGHT">From: </th>
<td>Tomaz Canabrava <a href="mailto:noreply@kde.org" target="_blank"><noreply@kde.org></a></td>
</tr>
<tr>
<th valign="BASELINE" nowrap align="RIGHT">Reply-To:
</th>
<td>KDE / Konsole
<a href="mailto:incoming+b8f09169d0d79ff3690046dd88efdfda@invent.kde.org" target="_blank"><incoming+b8f09169d0d79ff3690046dd88efdfda@invent.kde.org></a></td>
</tr>
<tr>
<th valign="BASELINE" nowrap align="RIGHT">To: </th>
<td><a href="mailto:kurt.hindenburg@gmail.com" target="_blank">kurt.hindenburg@gmail.com</a></td>
</tr>
</tbody>
</table>
<br>
<br>
<div>
<p style="color:rgb(119,119,119)">
<a href="https://invent.kde.org/tcanabrava" target="_blank">Tomaz Canabrava</a>
commented on a
discussion on <a href="https://invent.kde.org/kde/konsole/merge_requests/59#note_21242" target="_blank">src/Filter.cpp</a>:
</p>
<table>
<tbody>
<tr id="gmail-m_-4056930818790766732gmail-m_3541374584361615744">
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(240,240,240);padding:0px 5px" bgcolor="#fafafa" align="right">
360
</td>
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(240,240,240);padding:0px 5px" bgcolor="#fafafa" align="right">
329
</td>
<td style="padding-left:0.5em;padding-right:0.5em">
<pre style="margin:0px"> <span id="gmail-m_-4056930818790766732gmail-m_3541374584361615744LC329" lang="cpp"> <span style="color:rgb(51,51,51)">QRegularExpressionMatchIterator</span> <span style="color:rgb(51,51,51)">iterator</span><span>(</span><span style="color:rgb(51,51,51)">_searchText</span><span>.</span><span style="color:rgb(51,51,51)">globalMatch</span><span>(</span><span style="font-weight:600">*</span><span style="color:rgb(51,51,51)">text</span><span>));</span></span>
</pre>
</td>
</tr>
<tr id="gmail-m_-4056930818790766732gmail-m_3541374584361615744">
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(240,240,240);padding:0px 5px" bgcolor="#fafafa" align="right">
361
</td>
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(240,240,240);padding:0px 5px" bgcolor="#fafafa" align="right">
330
</td>
<td style="padding-left:0.5em;padding-right:0.5em">
<pre style="margin:0px"> <span id="gmail-m_-4056930818790766732gmail-m_3541374584361615744LC330" lang="cpp"> <span style="font-weight:600">while</span> <span>(</span><span style="color:rgb(51,51,51)">iterator</span><span>.</span><span style="color:rgb(51,51,51)">hasNext</span><span>())</span> <span>{</span></span>
</pre>
</td>
</tr>
<tr id="gmail-m_-4056930818790766732gmail-m_3541374584361615744">
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(240,240,240);padding:0px 5px" bgcolor="#fafafa" align="right">
362
</td>
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(240,240,240);padding:0px 5px" bgcolor="#fafafa" align="right">
331
</td>
<td style="padding-left:0.5em;padding-right:0.5em">
<pre style="margin:0px"> <span id="gmail-m_-4056930818790766732gmail-m_3541374584361615744LC331" lang="cpp"> <span style="color:rgb(51,51,51)">QRegularExpressionMatch</span> <span style="color:rgb(51,51,51)">match</span><span>(</span><span style="color:rgb(51,51,51)">iterator</span><span>.</span><span style="color:rgb(51,51,51)">next</span><span>());</span></span>
</pre>
</td>
</tr>
<tr id="gmail-m_-4056930818790766732gmail-m_3541374584361615744">
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(250,197,205);padding:0px 5px" bgcolor="#f9d7dc" align="right">
363
</td>
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(250,197,205);padding:0px 5px" bgcolor="#f9d7dc" align="right"> <br>
</td>
<td style="padding-left:0.5em;padding-right:0.5em" bgcolor="#fbe9eb">
<pre style="margin:0px">-<span id="gmail-m_-4056930818790766732gmail-m_3541374584361615744LC363" lang="cpp"></span>
</pre>
</td>
</tr>
<tr id="gmail-m_-4056930818790766732gmail-m_3541374584361615744">
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(250,197,205);padding:0px 5px" bgcolor="#f9d7dc" align="right">
364
</td>
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(250,197,205);padding:0px 5px" bgcolor="#f9d7dc" align="right"> <br>
</td>
<td style="padding-left:0.5em;padding-right:0.5em" bgcolor="#fbe9eb">
<pre style="margin:0px">-<span id="gmail-m_-4056930818790766732gmail-m_3541374584361615744LC364" lang="cpp"> <span style="color:rgb(68,85,136);font-weight:600">int</span> <span style="color:rgb(51,51,51)">startLine</span> <span style="font-weight:600">=</span> <span style="color:rgb(0,153,153)">0</span><span>;</span></span>
</pre>
</td>
</tr>
<tr id="gmail-m_-4056930818790766732gmail-m_3541374584361615744">
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(250,197,205);padding:0px 5px" bgcolor="#f9d7dc" align="right">
365
</td>
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(250,197,205);padding:0px 5px" bgcolor="#f9d7dc" align="right"> <br>
</td>
<td style="padding-left:0.5em;padding-right:0.5em" bgcolor="#fbe9eb">
<pre style="margin:0px">-<span id="gmail-m_-4056930818790766732gmail-m_3541374584361615744LC365" lang="cpp"> <span style="color:rgb(68,85,136);font-weight:600">int</span> <span style="color:rgb(51,51,51)">endLine</span> <span style="font-weight:600">=</span> <span style="color:rgb(0,153,153)">0</span><span>;</span></span>
</pre>
</td>
</tr>
<tr id="gmail-m_-4056930818790766732gmail-m_3541374584361615744">
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(250,197,205);padding:0px 5px" bgcolor="#f9d7dc" align="right">
366
</td>
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(250,197,205);padding:0px 5px" bgcolor="#f9d7dc" align="right"> <br>
</td>
<td style="padding-left:0.5em;padding-right:0.5em" bgcolor="#fbe9eb">
<pre style="margin:0px">-<span id="gmail-m_-4056930818790766732gmail-m_3541374584361615744LC366" lang="cpp"> <span style="color:rgb(68,85,136);font-weight:600">int</span> <span style="color:rgb(51,51,51)">startColumn</span> <span style="font-weight:600">=</span> <span style="color:rgb(0,153,153)">0</span><span>;</span></span>
</pre>
</td>
</tr>
<tr id="gmail-m_-4056930818790766732gmail-m_3541374584361615744">
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(250,197,205);padding:0px 5px" bgcolor="#f9d7dc" align="right">
367
</td>
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(250,197,205);padding:0px 5px" bgcolor="#f9d7dc" align="right"> <br>
</td>
<td style="padding-left:0.5em;padding-right:0.5em" bgcolor="#fbe9eb">
<pre style="margin:0px">-<span id="gmail-m_-4056930818790766732gmail-m_3541374584361615744LC367" lang="cpp"> <span style="color:rgb(68,85,136);font-weight:600">int</span> <span style="color:rgb(51,51,51)">endColumn</span> <span style="font-weight:600">=</span> <span style="color:rgb(0,153,153)">0</span><span>;</span></span>
</pre>
</td>
</tr>
<tr id="gmail-m_-4056930818790766732gmail-m_3541374584361615744">
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(250,197,205);padding:0px 5px" bgcolor="#f9d7dc" align="right">
368
</td>
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(250,197,205);padding:0px 5px" bgcolor="#f9d7dc" align="right"> <br>
</td>
<td style="padding-left:0.5em;padding-right:0.5em" bgcolor="#fbe9eb">
<pre style="margin:0px">-<span id="gmail-m_-4056930818790766732gmail-m_3541374584361615744LC368" lang="cpp"></span>
</pre>
</td>
</tr>
<tr id="gmail-m_-4056930818790766732gmail-m_3541374584361615744">
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(250,197,205);padding:0px 5px" bgcolor="#f9d7dc" align="right">
369
</td>
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(250,197,205);padding:0px 5px" bgcolor="#f9d7dc" align="right"> <br>
</td>
<td style="padding-left:0.5em;padding-right:0.5em" bgcolor="#fbe9eb">
<pre style="margin:0px">-<span id="gmail-m_-4056930818790766732gmail-m_3541374584361615744LC369" lang="cpp"> <span style="color:rgb(51,51,51)">getLineColumn</span><span>(</span><span style="color:rgb(51,51,51)">match</span><span>.</span><span style="color:rgb(51,51,51)">capturedStart</span><span>(),</span> <span style="color:rgb(51,51,51)">startLine</span><span>,</span> <span style="color:rgb(51,51,51)">startColumn</span><span>);</span></span>
</pre>
</td>
</tr>
<tr id="gmail-m_-4056930818790766732gmail-m_3541374584361615744">
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(250,197,205);padding:0px 5px" bgcolor="#f9d7dc" align="right">
370
</td>
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(250,197,205);padding:0px 5px" bgcolor="#f9d7dc" align="right"> <br>
</td>
<td style="padding-left:0.5em;padding-right:0.5em" bgcolor="#fbe9eb">
<pre style="margin:0px">-<span id="gmail-m_-4056930818790766732gmail-m_3541374584361615744LC370" lang="cpp"> <span style="color:rgb(51,51,51)">getLineColumn</span><span>(</span><span style="color:rgb(51,51,51)">match</span><span>.</span><span style="color:rgb(51,51,51)">capturedEnd</span><span>(),</span> <span style="color:rgb(51,51,51)">endLine</span><span>,</span> <span style="color:rgb(51,51,51)">endColumn</span><span>);</span></span>
</pre>
</td>
</tr>
<tr id="gmail-m_-4056930818790766732gmail-m_3541374584361615744">
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(199,240,210);padding:0px 5px" bgcolor="#ddfbe6" align="right"> <br>
</td>
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(199,240,210);padding:0px 5px" bgcolor="#ddfbe6" align="right">
332
</td>
<td style="padding-left:0.5em;padding-right:0.5em" bgcolor="#ecfdf0">
<pre style="margin:0px">+<span id="gmail-m_-4056930818790766732gmail-m_3541374584361615744LC332" lang="cpp"> <span style="font-weight:600">auto</span> <span>[</span><span style="color:rgb(51,51,51)">startLine</span><span>,</span> <span style="color:rgb(51,51,51)">startColumn</span><span>]</span> <span style="font-weight:600">=</span> <span style="color:rgb(51,51,51)">getLineColumn</span><span>(</span><span style="color:rgb(51,51,51)">match</span><span>.</span><span style="color:rgb(51,51,51)">capturedStart</span><span>());</span></span>
</pre>
</td>
</tr>
<tr id="gmail-m_-4056930818790766732gmail-m_3541374584361615744">
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(199,240,210);padding:0px 5px" bgcolor="#ddfbe6" align="right"> <br>
</td>
<td style="width:35px;color:rgba(0,0,0,0.3);border-right:1px solid rgb(199,240,210);padding:0px 5px" bgcolor="#ddfbe6" align="right">
333
</td>
<td style="padding-left:0.5em;padding-right:0.5em" bgcolor="#ecfdf0">
<pre style="margin:0px">+<span id="gmail-m_-4056930818790766732gmail-m_3541374584361615744LC333" lang="cpp"> <span style="font-weight:600">auto</span> <span>[</span><span style="color:rgb(51,51,51)">endLine</span><span>,</span> <span style="color:rgb(51,51,51)">endColumn</span><span>]</span> <span style="font-weight:600">=</span> <span style="color:rgb(51,51,51)">getLineColumn</span><span>(</span><span style="color:rgb(51,51,51)">match</span><span>.</span><span style="color:rgb(51,51,51)">capturedEnd</span><span>());</span></span>
</pre>
</td>
</tr>
</tbody>
</table>
<div>
<p dir="auto">can we bump to c++14 or 17? it's been six years
already since 14 :)</p>
</div>
</div>
<div style="margin-top:10px">
<p style="font-size:small;color:rgb(119,119,119)">
—
<br>
Reply to this email directly or <a href="https://invent.kde.org/kde/konsole/merge_requests/59#note_21242" target="_blank">view it on GitLab</a>.
<br>
You're receiving this email because of your account on
<a href="http://invent.kde.org" target="_blank">invent.kde.org</a>.
If you'd like to receive fewer emails, you can
<a href="https://invent.kde.org/sent_notifications/b8f09169d0d79ff3690046dd88efdfda/unsubscribe" target="_blank">unsubscribe</a>
from this thread or
adjust your notification settings.
</p>
</div>
</div>
</div>
</blockquote></div>