<table><tr><td style="">hindenburg added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17742">View Revision</a></tr></table><br /><div><div><p>Thanks still working on reading these changes.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17742#inline-105531">View Inline</a><span style="color: #4b4d51; font-weight: bold;">TerminalDisplay.cpp:1614</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QRegion</span> <span class="n">dirtyImageRegion</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">for<span class="bright">each</span></span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QRect</span> <span style="color: #aa2211">&<span class="bright"></span></span><span class="bright"> </span><span class="n">rect<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span> <span class="p">(</span><span class="n">pe</span><span style="color: #aa2211">-></span><span class="n">region</span><span class="p">()</span> <span style="color: #aa2211">&</span> <span class="bright"></span><span class="n"><span class="bright">contentsR</span>ect</span><span class="p">()).</span><span class="n">rects</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">for<span class="bright"></span></span><span class="bright"> </span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QRect</span> <span style="color: #aa2211">&</span><span style="color: #a0a000">rect<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">:</span></span> <span class="p">(</span><span class="n">pe</span><span style="color: #aa2211">-></span><span class="n">region</span><span class="p">()</span> <span style="color: #aa2211">&</span> <span class="bright"></span><span class="n"><span class="bright">r</span>ect</span><span class="p">()).</span><span class="n">rects</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">dirtyImageRegion</span> <span style="color: #aa2211">+=</span> <span class="n">widgetToImage</span><span class="p">(</span><span class="n">rect</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Did you mean to change contentsRect() to rect()?    rect() doesn't appear to take into account the scrollbar</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17742#inline-105534">View Inline</a><span style="color: #4b4d51; font-weight: bold;">TerminalDisplay.cpp:1633</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="bright"></span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">drawDimmed</span></span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="bright"></span><span style="color: #aa4000"><span class="bright">for</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n"><span class="bright">QRect</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"></span><span style="color: #a0a000"><span class="bright">rect</span></span><span class="bright"> </span><span class="p"><span class="bright">:</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">pe</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">region</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"> </span><span class="n"><span class="bright">rect</span></span><span class="bright"></span><span class="p"><span class="bright">()).</span></span><span class="bright"></span><span class="n"><span class="bright">rects</span></span><span class="bright"></span><span class="p"><span class="bright">()</span>)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">paint</span><span class="p">.</span><span class="n">fillRect</span><span class="p">(</span><span class="n">rect</span><span class="p">,</span> <span class="n">dimColor</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">same here</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17742#inline-105535">View Inline</a><span style="color: #4b4d51; font-weight: bold;">TerminalDisplay.cpp:2035</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QRect</span> <span class="n">result</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">result</span><span class="p">.</span><span class="n">setLeft</span><span class="p">(</span>  <span class="n">qMin</span><span class="p">(</span><span class="n">_usedColumns</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">,</span> <span class="n">qMax</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span class="p">(</span><span class="n">widgetArea</span><span class="p">.</span><span class="n">left</span><span class="p">()</span>   <span style="color: #aa2211">-</span> <span class="n">contentsRect</span><span class="p">().</span><span class="n">left</span><span class="p">()<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"> </span><span class="n"><span class="bright">_contentRect</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">left</span></span><span class="bright"></span><span class="p"><span class="bright">()</span>)</span> <span style="color: #aa2211">/</span> <span class="n">_fontWidth</span> <span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">result</span><span class="p">.</span><span class="n">setTop</span><span class="p">(</span>   <span class="n">qMin</span><span class="p">(</span><span class="n">_usedLines</span>   <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">,</span> <span class="n">qMax</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span class="p">(</span><span class="n">widgetArea</span><span class="p">.</span><span class="n">top</span><span class="p">()</span>    <span style="color: #aa2211">-</span> <span class="n">contentsRect</span><span class="p">().</span><span class="n">top</span><span class="p">()</span> <span class="bright"> </span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"> </span><span class="n"><span class="bright">_contentRect</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">top</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span class="p">)</span> <span style="color: #aa2211">/</span> <span class="n">_fontHeight</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">result</span><span class="p">.</span><span class="n">setLeft</span><span class="p">(</span>  <span class="n">qMin</span><span class="p">(</span><span class="n">_usedColumns</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">,</span> <span class="n">qMax</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span class="p">(</span><span class="n">widgetArea</span><span class="p">.</span><span class="n">left</span><span class="p">()</span>   <span style="color: #aa2211">-</span> <span class="n">contentsRect</span><span class="p">().</span><span class="n">left</span><span class="p">())</span> <span style="color: #aa2211">/</span> <span class="n">_fontWidth</span> <span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">result</span><span class="p">.</span><span class="n">setTop</span><span class="p">(</span>   <span class="n">qMin</span><span class="p">(</span><span class="n">_usedLines</span>   <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">,</span> <span class="n">qMax</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span class="p">(</span><span class="n">widgetArea</span><span class="p">.</span><span class="n">top</span><span class="p">()</span>    <span style="color: #aa2211">-</span> <span class="n">contentsRect</span><span class="p">().</span><span class="n">top</span><span class="p">()</span> <span class="p">)</span> <span style="color: #aa2211">/</span> <span class="n">_fontHeight</span><span class="p">)));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Was the old code having 2 contentsRect().left()  a mistake?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17742">https://phabricator.kde.org/D17742</a></div></div><br /><div><strong>To: </strong>sandsmark, hindenburg, Konsole<br /><strong>Cc: </strong>konsole-devel, Konsole, gennad, maciejn, thsurrel, ngraham, maximilianocuria, hindenburg<br /></div>