<table><tr><td style="">sandsmark added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18735">View Revision</a></tr></table><br /><div><div><p>thanks for doing this, been dreading doing something like it myself. :-)</p>

<p>looks good in general to me.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18735#inline-104759">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LineBlockCharacters.cpp:166</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">template</span> <span style="color: #aa2211"><</span><span style="color: #aa4000">typename</span> <span class="n">T</span><span style="color: #aa2211">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">inline</span> <span style="color: #aa4000">static</span> <span class="n">T</span> <span class="n">rotl</span><span class="p">(</span><span class="n">T</span> <span class="n">value</span><span class="p">,</span> <span class="n">quint8</span> <span class="n">amount</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">rotl is a pretty normal acronym, but probably more readable if it's called rotateBitsLeft or something?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18735#inline-104757">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LineBlockCharacters.cpp:248</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QPainterPath</span> <span class="n">ppl</span><span class="p">;</span> <span style="color: #74777d">// PainterPath for light lines (Painter Path Light)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QPainterPath</span> <span class="n">pph</span><span class="p">;</span> <span style="color: #74777d">// PainterPath for heavy lines (Painter Path Heavy)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">lightPath, heavyPath, maybe?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18735#inline-104758">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LineBlockCharacters.cpp:273</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">// largest packedLineTypes value.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">uint</span> <span class="n">iT</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span> <span style="color: #74777d">// top index</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">quint8</span> <span class="n">normalizedPackedLineTypes</span> <span style="color: #aa2211">=</span> <span class="n">packedLineTypes</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">topIndex?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18735#inline-104756">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LineBlockCharacters.cpp:282</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">uint</span> <span class="n">iR</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">iT</span><span style="color: #aa2211">+</span><span style="color: #601200">1</span><span class="p">)</span> <span style="color: #aa2211">%</span> <span class="n">LinesNum</span><span class="p">;</span> <span style="color: #74777d">// right index</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">uint</span> <span class="n">iB</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">iT</span><span style="color: #aa2211">+</span><span style="color: #601200">2</span><span class="p">)</span> <span style="color: #aa2211">%</span> <span class="n">LinesNum</span><span class="p">;</span> <span style="color: #74777d">// bottom index</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">not a fan of two-letter abbreviated variable names (against the Qt code style fwiw).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18735#inline-104761">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LineBlockCharacters.cpp:449</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">switch</span> <span class="p">(</span><span class="n">code</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">case</span> <span style="color: #601200">0x4C</span><span style="color: #aa2211">:</span> <span class="n">lp</span> <span style="color: #aa2211">=</span> <span class="p">{</span><span style="color: #601200">2</span><span class="p">,</span> <span class="n">Horizontal</span><span class="p">,</span> <span class="n">halfGapH</span>  <span class="p">,</span> <span class="n">lightPen</span><span class="p">};</span> <span style="color: #aa4000">break</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">maybe a comment to show which is which? in case of future debugging.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18735#inline-104762">View Inline</a><span style="color: #4b4d51; font-weight: bold;">TerminalDisplay.cpp:761</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">auto</span> <span class="n">origClipping</span> <span style="color: #aa2211">=</span> <span class="n">painter</span><span class="p">.</span><span class="n">hasClipping</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">auto</span> <span class="n">origClipRegion</span> <span style="color: #aa2211">=</span> <span class="n">painter</span><span class="p">.</span><span class="n">clipRegion</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">painter</span><span class="p">.</span><span class="n">setClipRect</span><span class="p">(</span><span class="n">rect</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">no idea what these types are, isn't the first one just a bool? auto feels unnecessary (and I'm allergic to auto).</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18735">https://phabricator.kde.org/D18735</a></div></div><br /><div><strong>To: </strong>mglb, Konsole, VDG, fvogt<br /><strong>Cc: </strong>sandsmark, fvogt, konsole-devel, maciejn, thsurrel, ngraham, maximilianocuria, hindenburg<br /></div>