<table><tr><td style="">fvogt requested changes to this revision.<br />fvogt added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18735">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18735#inline-104387">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LineBlockCharacters.cpp:171</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">return</span> <span class="n">value</span> <span style="color: #aa2211"><<</span> <span class="n">amount</span> <span style="color: #aa2211">|</span> <span class="n">value</span> <span style="color: #aa2211">>></span> <span class="p">(</span><span style="color: #aa4000">sizeof</span><span class="p">(</span><span class="n">value</span><span class="p">)</span> <span style="color: #aa2211">*</span> <span style="color: #601200">8</span> <span style="color: #aa2211">-</span> <span class="n">amount</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Stray  ';' - results in compiler warning.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18735#inline-104393">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LineBlockCharacters.cpp:193</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span class="n">qreal</span> <span class="n">lightWidth</span> <span style="color: #aa2211">=</span> <span class="n">qRound</span><span class="p">(</span><span class="n">qMax</span><span class="p">(</span><span class="n">fontWidth</span> <span style="color: #aa2211">*</span> <span class="n">LightWidthToFontSizeRatio</span> <span style="color: #aa2211">*</span> <span class="n">boldCoeff</span><span class="p">,</span> <span style="color: #601200">1.0</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span class="n">qreal</span> <span class="n">heavyHalfExtraWidth</span> <span style="color: #aa2211">=</span> <span class="n">qRound</span><span class="p">(</span><span class="n">qMax</span><span class="p">(</span><span class="n">lightWidth</span> <span style="color: #aa2211">*</span> <span class="n">HeavyHalfExtraToLightRatio</span><span class="p">,</span> <span style="color: #601200">1.0</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">For <tt style="background: #ebebeb; font-size: 13px;">fontWidth</tt> less than 8 this returns 1 for both bold and normal lines. Intentional?</p>

<p style="padding: 0; margin: 8px;">IMO increasing the <tt style="background: #ebebeb; font-size: 13px;">LightWidthToFontSizeRatio</tt> to <tt style="background: #ebebeb; font-size: 13px;">1/5</tt>  is acceptable.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18735#inline-104389">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LineBlockCharacters.h:62</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">     */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #304a96">inline</span> <span style="color: #aa4000">void</span> <span style="color: #004012">draw</span><span class="p">(</span><span class="n">QPainter</span> <span style="color: #aa2211">&</span><span class="n">paint</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QRect</span> <span style="color: #aa2211">&</span><span class="n">cellRect</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QChar</span> <span style="color: #aa2211">&</span><span class="n">chr</span><span class="p">,</span> <span style="color: #aa4000">bool</span> <span class="n">bold</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">draw</span><span class="p">(</span><span class="n">paint</span><span class="p">,</span> <span class="n">cellRect</span><span class="p">.</span><span class="n">x</span><span class="p">(),</span> <span class="n">cellRect</span><span class="p">.</span><span class="n">y</span><span class="p">(),</span> <span class="n">cellRect</span><span class="p">.</span><span class="n">width</span><span class="p">(),</span> <span class="n">cellRect</span><span class="p">.</span><span class="n">height</span><span class="p">(),</span> <span class="n">chr</span><span class="p">,</span> <span class="n">bold</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">AFAICT only this variant is actually used - so is the other one necessary at all?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18735">https://phabricator.kde.org/D18735</a></div></div><br /><div><strong>To: </strong>mglb, Konsole, VDG, fvogt<br /><strong>Cc: </strong>fvogt, konsole-devel, maciejn, thsurrel, ngraham, maximilianocuria, hindenburg<br /></div>