<table><tr><td style="">ngraham edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-lptloqjqxjrunci/">(Show Details)</a>
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17747">View Revision</a></tr></table><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>the icon. There are <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">two primary</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">several</span> reasons for this:<br />
1. <span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">*</span>Conceptual:<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">*</span> When only non-default profile icons show up in the tab,<div style="padding: 8px 0;">...</div>2. <span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">*</span>Aesthetic:<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">*</span> you no longer have the same icon in every tab by default,<div style="padding: 8px 0;">...</div>3. <span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">*</span>Icon-specific:<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">*</span> the `utilities-terminal` icon doesn't look good against<div style="padding: 8px 0;">...</div>4. <span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">*</span>Code hygiene:<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">*</span> reduce<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">s</span> a bit of redundancy in the session controller code.<div style="padding: 8px 0;">...</div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17747">https://phabricator.kde.org/D17747</a></div></div><br /><div><strong>To: </strong>ngraham, Konsole, VDG, ndavis<br /><strong>Cc: </strong>abetts, hindenburg, konsole-devel, thsurrel, ngraham, maximilianocuria<br /></div>