<table><tr><td style="">mglb added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17744">View Revision</a></tr></table><br /><div><div><p>Awesome! It was a thing I wanted to be made better. But there are some problems:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item"><ul class="remarkup-list">
<li class="remarkup-list-item">Invoke search, type text: all nice, I see current search line and remaining search results</li>
<li class="remarkup-list-item">Close search</li>
<li class="remarkup-list-item">Invoke search again: There is no current line (this is OK) and no dim (not OK) - search results are barely visible (without transparency they are not visible at all)</li>
</ul></li>
<li class="remarkup-list-item">Font size change (Ctrl+Scroll, Ctrl++, Ctrl+-) during search is not handled</li>
</ol>
<p>Pedantic things:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Selecting search result removes the rounded rect's rounding <a href="https://phabricator.kde.org/F6502287" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6502287: rounded-corners.png</a></li>
</ul>
<p>Ideas (maybe for future):</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">What do you think about making the lines 1px tall, drawn on inner edge of the rectangle? This would match lines in Breeze widget style.</li>
<li class="remarkup-list-item">Configurable colors, or colors taken from system theme/konsole theme</li>
</ul></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17744#inline-97543">View Inline</a><span style="color: #4b4d51; font-weight: bold;">TerminalDisplay.cpp:1662</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">paint</span><span class="p">.</span><span class="n">drawLine</span><span class="p">(</span><span class="n">QLineF</span><span class="p">(</span><span class="n">_searchResultRect</span><span class="p">.</span><span class="n">topLeft</span><span class="p">(),</span> <span class="n">_searchResultRect</span><span class="p">.</span><span class="n">topRight</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">paint</span><span class="p">.</span><span class="n">drawLine</span><span class="p">(</span><span class="n">QLineF</span><span class="p">(</span><span class="n">_searchResultRect</span><span class="p">.</span><span class="n">bottomLeft</span><span class="p">(),</span> <span class="n">_searchResultRect</span><span class="p">.</span><span class="n">bottomRight</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Lines are not drawn on a margin:<br />
<a href="https://phabricator.kde.org/F6502251" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6502251: lineless-margin.png</a><br />
Also, the bottom line is 1px off. It needs to be translated down, like the bottom shaded area.</p>
<p style="padding: 0; margin: 8px;">Fix:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">@@ -1639,4 +1639,6 @@ void TerminalDisplay::paintEvent(QPaintEvent* pe)
_searchResultRect.setTop(_searchResultRect.top() - _fontHeight / 3);
_searchResultRect.setBottom(_searchResultRect.bottom() + _fontHeight / 3);
+ _searchResultRect.setLeft(0);
+ _searchResultRect.setRight(contentsRect().width());
QColor shadeColor(0, 0, 0, 192);
@@ -1648,5 +1650,5 @@ void TerminalDisplay::paintEvent(QPaintEvent* pe)
// Lightly shade line with results
shadeColor.setAlpha(120);
- paint.fillRect(0, _searchResultRect.top(), contentsRect().width(), _searchResultRect.height(), shadeColor);
+ paint.fillRect(_searchResultRect, shadeColor);
} else {
_searchResultRect = QRect();
@@ -1659,6 +1661,6 @@ void TerminalDisplay::paintEvent(QPaintEvent* pe)
if (drawSearchResults) {
paint.setPen(QPen(QColor(255, 255, 255, 64), 2));
- paint.drawLine(QLineF(_searchResultRect.topLeft(), _searchResultRect.topRight()));
- paint.drawLine(QLineF(_searchResultRect.bottomLeft(), _searchResultRect.bottomRight()));
+ paint.drawLine(QLine(_searchResultRect.topLeft(), _searchResultRect.topRight()));
+ paint.drawLine(QLine(_searchResultRect.bottomLeft(), _searchResultRect.bottomRight()).translated(0, 1));
}</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17744">https://phabricator.kde.org/D17744</a></div></div><br /><div><strong>To: </strong>sandsmark, hindenburg, Konsole, thsurrel, tcanabrava<br /><strong>Cc: </strong>mglb, konsole-devel, Konsole, thsurrel, ngraham, maximilianocuria, hindenburg<br /></div>