<table><tr><td style="">hindenburg added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13847">View Revision</a></tr></table><br /><div><div><p>I don't mind the smaller ones, but I'm not 100% sure about some of the multi-line ones.</p>
<p>Also, we use the ==nullptr per "readability-implicit-bool-cast" - I think it makes the code easier to understand and avoids confusion about what you're checking (implicit casts).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13847">https://phabricator.kde.org/D13847</a></div></div><br /><div><strong>To: </strong>tcanabrava, hindenburg, Konsole<br /><strong>Cc: </strong>konsole-devel, herrold, ngraham, maximilianocuria, hindenburg<br /></div>