<table><tr><td style="">tcanabrava added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13511">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D13511#281810" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D13511#281810</a>, <a href="https://phabricator.kde.org/p/hindenburg/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@hindenburg</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Are you still working on this or could we commit this as-is? I'd like to get this in as soon as possible for testing for 18.08; we can always revert or apply future patches.</p>
<p>Also, I note that when scrolling up and then back down in a sessions, the searchbar disappears (ie, the searchbar scrolls up off the visible screen).</p>
<p>I don't want to rush, just curious where you at.</p></div>
</blockquote>
<p>Safe to merge, the things I need to do are minimal and I'll try to send a follow up patch for that over the weekend.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13511">https://phabricator.kde.org/D13511</a></div></div><br /><div><strong>To: </strong>tcanabrava, Konsole, hindenburg<br /><strong>Cc: </strong>ahmadsamir, ngraham, konsole-devel, herrold, maximilianocuria, hindenburg<br /></div>