<table><tr><td style="">ahmadsamir marked 7 inline comments as done.<br />ahmadsamir added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12015">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D12015#241801" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D12015#241801</a>, <a href="https://phabricator.kde.org/p/ltoscano/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ltoscano</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>The doc team was automatically added as subscriber.<br />
Regarding the entity, just expand it inline, or define the entity in this file: we add it for people who have more contributions (and it would introduce a dependency on a new version of Frameworks, so you would need to keep the expanded version here anyway).</p></div>
</blockquote>
<p>OK, thanks for the pointers.</p>
<p><a href="https://phabricator.kde.org/p/yurchor/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@yurchor</a>: thanks for the review.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12015#inline-60314">View Inline</a><span style="color: #4b4d51; font-weight: bold;">yurchor</span> wrote in <span style="color: #4b4d51; font-weight: bold;">index.docbook:1332</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Would it be better to have multiple sect1s (sect2s -> sect1s) in a chapter rather than have just one?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Actually I want all the content to be in one page, since it's all relevant and the user would have to keep going back and forth between multiple files to look stuff up.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12015#inline-60313">View Inline</a><span style="color: #4b4d51; font-weight: bold;">yurchor</span> wrote in <span style="color: #4b4d51; font-weight: bold;">index.docbook:1341</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">going -> go</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I am not a native speaker, but "going" sounds (more) correct to me.</p>
<p style="padding: 0; margin: 8px;">I would use "go" like this:<br />
To open the Key Bindings Editor "click" the menu entry ........, and "go" to the keyboard tab.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12015#inline-60312">View Inline</a><span style="color: #4b4d51; font-weight: bold;">yurchor</span> wrote in <span style="color: #4b4d51; font-weight: bold;">index.docbook:1363</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Ctrl keys _are_ not pressed.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It was supposed to be "key", I've fixed that.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12015">https://phabricator.kde.org/D12015</a></div></div><br /><div><strong>To: </strong>ahmadsamir, Konsole, hindenburg, yurchor<br /><strong>Cc: </strong>ltoscano, kde-doc-english, hindenburg, Konsole, herrold, ngraham<br /></div>