<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128838/">https://git.reviewboard.kde.org/r/128838/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 9th, 2016, 4:38 a.m. UTC, <b>Martin Tobias Holmedahl Sandsmark</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the actual issue is in kpty and is fixed by this: https://git.reviewboard.kde.org/r/128790/</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That's fine - this was a good time to look at the code and fix some issues about invalid initial dirs - Andreas, I fixed this in Session.cpp so both the Part and normal Konsole will benefit.</p></pre>
<br />
<p>- Kurt</p>
<br />
<p>On September 5th, 2016, 3:10 p.m. UTC, Andreas Cord-Landwehr wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Konsole, Kurt Hindenburg and Martin Tobias Holmedahl Sandsmark.</div>
<div>By Andreas Cord-Landwehr.</div>
<p style="color: grey;"><i>Updated Sept. 5, 2016, 3:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If the startup folder does not exist, the QProcess starting /bin/bash
within the startprocess of the embedded Konsole part does not correctly
return; in particular, there is not even a correct return after the
specified timeout. See the following stacktrace:
0 0x00007ffff027817d in read () at ../sysdeps/unix/syscall-template.S:84
1 0x00007ffff0fecc0c in forkfd_wait(int, forkfd_info*, rusage*) (ffd=<optimized out>, info=info@entry=0x7fffffffc780, rusage=rusage@entry=0x0) at io/../../3rdparty/forkfd/forkfd.c:818
2 0x00007ffff0fe948a in QProcessPrivate::waitForDeadChild() (this=this@entry=0xf71b20) at io/qprocess_unix.cpp:899
3 0x00007ffff0f8def3 in QProcessPrivate::_q_startupNotification() (this=this@entry=0xf71b20) at io/qprocess.cpp:1234
4 0x00007ffff0fe8bc8 in QProcessPrivate::waitForStarted(int) (this=0xf71b20, msecs=<optimized out>) at io/qprocess_unix.cpp:736
5 0x00007fffcb8e95cc in Konsole::Pty::start(QString const&, QStringList const&, QStringList const&) (this=0xf75820, programName=..., programArguments=..., environmentList=...) at /opt/kde/src/kde/applications/konsole/src/Pty.cpp:260
6 0x00007fffcb8f6f89 in Konsole::Session::run() (this=0xf72d40) at /opt/kde/src/kde/applications/konsole/src/Session.cpp:487
7 0x00007fffcbbe32e9 in Konsole::Part::showShellInDir(QString const&) (this=0xf667f0, dir=...) at /opt/kde/src/kde/applications/konsole/src/Part.cpp:145
8 0x00007ffff7b7aebc in TerminalPanel::showEvent(QShowEvent*) (this=0x831910, event=0x7fffffffd070) at /opt/kde/src/kde/applications/dolphin/src/panels/terminal/terminalpanel.cpp:121
9 0x00007ffff1c41b38 in QWidget::event(QEvent*) (this=0x831910, event=0x7fffffffd070) at kernel/qwidget.cpp:9141
10 0x00007ffff1bfdf8c in QApplicationPrivate::notify_helper(QObject*, QEvent*) (this=<optimized out>, receiver=0x831910, e=0x7fffffffd070) at kernel/qapplication.cpp:3799
11 0x00007ffff1c05476 in QApplication::notify(QObject*, QEvent*) (this=0x7fffffffd370, receiver=0x831910, e=0x7fffffffd070) at kernel/qapplication.cpp:3556
12 0x00007ffff104ec58 in QCoreApplication::notifyInternal2(QObject*, QEvent*) (receiver=receiver@entry=0x831910, event=event@entry=0x7fffffffd070) at kernel/qcoreapplication.cpp:988
13 0x00007ffff1c3ebc3 in QWidgetPrivate::show_helper() (event=0x7fffffffd070, receiver=0x831910) at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:231
14 0x00007ffff1c3ebc3 in QWidgetPrivate::show_helper() (this=0x8319a0) at kernel/qwidget.cpp:7909
15 0x00007ffff1c3e946 in QWidgetPrivate::show_recursive() (this=<optimized out>) at kernel/qwidget.cpp:7780
16 0x00007ffff1c3ea47 in QWidgetPrivate::showChildren(bool) (this=this@entry=0x82e300, spontaneous=spontaneous@entry=false) at kernel/qwidget.cpp:8286
17 0x00007ffff1c3eabf in QWidgetPrivate::show_helper() (this=0x82e300) at kernel/qwidget.cpp:7856
18 0x00007ffff1c3e946 in QWidgetPrivate::show_recursive() (this=<optimized out>) at kernel/qwidget.cpp:7780
19 0x00007ffff1c3ea47 in QWidgetPrivate::showChildren(bool) (this=this@entry=0x6ec6e0, spontaneous=spontaneous@entry=false) at kernel/qwidget.cpp:8286
20 0x00007ffff1c3eabf in QWidgetPrivate::show_helper() (this=this@entry=0x6ec6e0) at kernel/qwidget.cpp:7856
21 0x00007ffff1c415fd in QWidget::setVisible(bool) (this=0x6c38c0, visible=<optimized out>) at kernel/qwidget.cpp:8205
22 0x00007ffff7b29546 in kdemain(int, char**) (argc=1, argv=0x7fffffffdb28) at /opt/kde/src/kde/applications/dolphin/src/main.cpp:139
23 0x0000000000400b78 in main(int, char**) (argc=1, argv=0x7fffffffdb28) at /opt/kde/build/kde/applications/dolphin/src/dolphin_dummy.cpp:3</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">manual testing</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Part.cpp <span style="color: grey">(07f8cf7b3f599494d4dbecb2ed6facc3da26d0eb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128838/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>