<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128787/">https://git.reviewboard.kde.org/r/128787/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The reason for using KProcess::pid() was that it returned the actual PID
on Windows while QProcess::pid() returned a _PROCESS_INFORMATION
pointer.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">However now QProcess::pid() which KProcess uses is obsolete/deprecated,
and QProcess::processId() returns what we want, the code in
KProcess::pid() and QProcess::processId() is now identical.
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also changes the PID usage to qint64, which is what Qt uses for PIDs.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Part.h <span style="color: grey">(bbe6510)</span></li>
<li>src/Part.cpp <span style="color: grey">(07f8cf7)</span></li>
<li>src/ProcessInfo.h <span style="color: grey">(3590651)</span></li>
<li>src/ProcessInfo.cpp <span style="color: grey">(6a5ac2d)</span></li>
<li>src/Pty.h <span style="color: grey">(5996f95)</span></li>
<li>src/Pty.cpp <span style="color: grey">(f76edfb)</span></li>
<li>src/Session.h <span style="color: grey">(397b515)</span></li>
<li>src/Session.cpp <span style="color: grey">(14a0fbb)</span></li>
<li>src/autotests/DBusTest.cpp <span style="color: grey">(814e4f2)</span></li>
<li>src/autotests/TerminalInterfaceTest.cpp <span style="color: grey">(2cce10a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128787/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>