<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128405/">https://git.reviewboard.kde.org/r/128405/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One issue is that if I have my own color scheme set, not one of the defaults loaded globally, it sets all the faint colors to black (which doesn't work well with a dark color scheme).
I think it can be solved by adding something like this to ColorScheme::readColorEntry:
if (!configGroup.hasKey("Color")) {
return;
}
Then it preserves the default, which might be better. A better alternative again would be to copy from one of the other groups, but that would be a bit more complex.</pre>
<br />
<p>- Martin Tobias Holmedahl Sandsmark</p>
<br />
<p>On July 8th, 2016, 6:10 p.m. UTC, Antonio Russo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Antonio Russo.</div>
<p style="color: grey;"><i>Updated July 8, 2016, 6:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed outdated comments and unused constant RE_INTENSIVE
Replace a quint8 flag type with a uniform RenditionFlag
typedef (now quint16) in preparation for additional flags.
Add faint intensity support (SGR 2)
Four changes implementing faint intensity:
a) A new rendition flag RE_FAINT
b) Vt102Emulation to actually render text with
a different color
c) ColorScheme support for "faint" colors
d) ColorSchemeEditor support
ColorScheme updates for faint intensities
Add strikeout support (SGR 9)
Add conceal support (SGR 8)
Add overline support (SGR 53)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have been running this patchset for the last several months without issue.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/color-schemes/BlackOnLightYellow.colorscheme <span style="color: grey">(289452df8731aba27bde80b70687ad01128a8da6)</span></li>
<li>data/color-schemes/BlackOnRandomLight.colorscheme <span style="color: grey">(8184e29c54d19c45d47b24274099c4a80140adce)</span></li>
<li>data/color-schemes/BlackOnWhite.colorscheme <span style="color: grey">(be9ba2f193eb6a5e15f4ee12d06d2184c520601a)</span></li>
<li>data/color-schemes/BlueOnBlack.colorscheme <span style="color: grey">(f72da32da5472c2aefb9da8754fe20ed7ccff6da)</span></li>
<li>data/color-schemes/Breeze.colorscheme <span style="color: grey">(a9031d6ae1f260f5d8bb394e542cd38cbcad3173)</span></li>
<li>data/color-schemes/DarkPastels.colorscheme <span style="color: grey">(110f72bc26e929db87570ebd8fd5f382c70d0359)</span></li>
<li>data/color-schemes/GreenOnBlack.colorscheme <span style="color: grey">(df0f3b309e5d93ea052114ad7aec64191ac340dc)</span></li>
<li>data/color-schemes/Linux.colorscheme <span style="color: grey">(3cb0381132449bd61daccaa591fd6b3460326bb0)</span></li>
<li>data/color-schemes/RedOnBlack.colorscheme <span style="color: grey">(207f892de3e2290e7ef1be8aa7c4d847b26f66c8)</span></li>
<li>data/color-schemes/Solarized.colorscheme <span style="color: grey">(e3f0aee0478c0e77231c3463ef2d8059b6dbdd55)</span></li>
<li>data/color-schemes/SolarizedLight.colorscheme <span style="color: grey">(ea064f4e4aa519a0652ba962cfd2f57906681758)</span></li>
<li>data/color-schemes/WhiteOnBlack.colorscheme <span style="color: grey">(7307c5d40d741a9fa188468c461cddbb90179e86)</span></li>
<li>src/Character.h <span style="color: grey">(a722bafb47b166defc88324bc58f33017630cd07)</span></li>
<li>src/CharacterColor.h <span style="color: grey">(8557e1bec3f04b72c89831f12f6e283275983952)</span></li>
<li>src/ColorScheme.cpp <span style="color: grey">(1281433dc06274d970b96162711b78938695be09)</span></li>
<li>src/ColorSchemeEditor.cpp <span style="color: grey">(9e227a4a365779372ff15cc4af77e0118ce30fec)</span></li>
<li>src/History.h <span style="color: grey">(dcd38195101a6f95b22e7922d2a2268562ec1eed)</span></li>
<li>src/Screen.h <span style="color: grey">(f73add14ecf7787dabe07850c586d970729367f5)</span></li>
<li>src/Screen.cpp <span style="color: grey">(ffc3fd15f158079373b47d261fd33fc9f4a95192)</span></li>
<li>src/TerminalCharacterDecoder.h <span style="color: grey">(18dd0302ef23e6cdb684c44952d4adddc432e6dc)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(63e40ea7820d9be9a3c71293ff1a33a629fd111c)</span></li>
<li>src/Vt102Emulation.cpp <span style="color: grey">(6e1734b451f95e0b498218d992f8b0ee007e5170)</span></li>
<li>src/autotests/CharacterColorTest.cpp <span style="color: grey">(0fefa607a5ab75794b463a0c804cb619bddbe5c5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128405/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>