<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128299/">https://git.reviewboard.kde.org/r/128299/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 3rd, 2016, 2:48 p.m. UTC, <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Someone from Debian had asked about providing a new patch which I did for them. However, I've been reluctant to add distro specific code in Konsole.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd generally agree. In this particular case the code is coming at pretty much no cost to us. Presumably konsole will always have cmdline arguments and as such getting -T is a matter of copy and paste and changing the strings. In fact as long as we have a way to set options hidden it doesn't even matter what is in the strings (e.g. this option isn't using i18n() because of that).
What remains is the plus side of having an in-code reminder to not use -T for anything else so we don't cause incompatibility with the debian policy by accident and the fact that all debian derived systems (of which there are a few ;)) do not need to carry and update the -T patch as updating pathes is ever so much more work than a simple copy and paste in-code.
It's arguably also in our interest to have this sorted on a Konsole level as we can make sure that it is hidden, so debian-based systems don't list it in --help so users don't try it and then notice that the option doesn't work and then report bug reports on bugs.kde.org about this. I think everyone will be happier if we do it properly instead of hoping that someone is going to do it proper enough to not annoy anyone :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That said, I am not particularly attached to this since I think the debian policy is stupidly overzealous in specifying -T.</p></pre>
<br />
<p>- Harald</p>
<br />
<p>On June 28th, 2016, 8:14 a.m. UTC, Harald Sitter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Konsole and Kurt Hindenburg.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated June 28, 2016, 8:14 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">debian policy for reasons beyond my apprehension wants a -T option to
set the window title (like in xterm).
to make debian's (and derivate's) life easier let's support a no-op
-T option but hide it. this option will not appear in --help output
but be accepted by the parser all the same.
this enables Debian and friends to drop a long standing useless patch
and at the same time prevents us from introducing a conflicting -T in
the future.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">builds</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">not listed in --help</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">konsole -T yolo works</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/main.cpp <span style="color: grey">(d8b4b2964471a8edc1b711bbc8220624d33690bb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128299/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>