<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127625/">https://git.reviewboard.kde.org/r/127625/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I thought I had fixed the semi-random crashes by moving the KDBusService creation to before the creation of most of the other objects on the stack, but it still happens for some reason.
The crash happens often, but not always, when instantiating KDBusService with KDBusService::Unique, and I have honestly no idea why it happens, but it happens in the cleanup of static data, I think?
The (almost useless) backtrace is like this, most of the time:
(gdb) thread apply all bt
Thread 2 (Thread 0x7f1748fda800 (LWP 11861)):
#0 0x00007f1748eb9604 in _dl_sort_fini () from /lib64/ld-linux-x86-64.so.2
#1 0x00007f1748eb98ea in _dl_fini () from /lib64/ld-linux-x86-64.so.2
#2 0x00007f17420a7c38 in __run_exit_handlers () from /usr/lib/libc.so.6
#3 0x00007f17420a7c85 in exit () from /usr/lib/libc.so.6
#4 0x00007f1745872cd3 in KDBusService::KDBusService(QFlags<KDBusService::StartupOption>, QObject*) () from /usr/lib/libKF5DBusAddons.so.5
#5 0x00007f1748c7a98a in kdemain (argc=1, argv=0x7ffce18424b8) at ../src/main.cpp:110
#6 0x0000000000400a58 in main (argc=1, argv=0x7ffce18424b8) at src/konsole_dummy.cpp:3
Thread 1 (Thread 0x7f1733a0c700 (LWP 11862)):
#0 0x00007f173532ea99 in ?? ()
#1 0x00007f1733a0be10 in ?? ()
#2 0x00000000020703a0 in ?? ()
#3 0x00007f1733a0be50 in ?? ()
#4 0x0000000002070710 in ?? ()
#5 0x00007ffce184193f in ?? ()
#6 0x00007f1742d5ade8 in ?? () from /usr/lib/libQt5Core.so.5
(gdb)
I'm fairly certain that it is not a bug in the konsole code, but we might be constructing something in the wrong order or something.
But in any case it doesn't really affect the functionality, except that it clutters up coredumpctl with useless coredumps.</pre>
<br />
<p>- Martin Tobias Holmedahl Sandsmark</p>
<br />
<p>On April 10th, 2016, 2:31 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Konsole, Kai Uwe Broulik, David Faure, and Kurt Hindenburg.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>
<p style="color: grey;"><i>Updated April 10, 2016, 2:31 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Continuation of https://git.reviewboard.kde.org/r/126808/ </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Pretty much all of this is done by D?vis Mos?ns in that review, I just fixed some of the issues with it:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The names of the command line arguments.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Warning about empty argument lists when opening a new window in an existing instance.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">An unimportant crash when opening a new window in an existing instance (it was happening on exit).</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Creation/adding of the actions for the standalone Konsole application.</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have tried to trigger edge cases, and I've been using this daily for over a month.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(273214c)</span></li>
<li>src/Application.h <span style="color: grey">(b7389ef)</span></li>
<li>src/Application.cpp <span style="color: grey">(326c766)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(6798079)</span></li>
<li>src/MainWindow.h <span style="color: grey">(500b395)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(d2143b8)</span></li>
<li>src/SessionController.h <span style="color: grey">(02f51d9)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(27f9e9f)</span></li>
<li>src/SessionListModel.cpp <span style="color: grey">(fb28bb8)</span></li>
<li>src/autotests/PartTest.cpp <span style="color: grey">(b3e7797)</span></li>
<li>src/main.cpp <span style="color: grey">(5e1420e)</span></li>
<li>src/settings/ProfileSettings.cpp <span style="color: grey">(d6dafbf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127625/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>