<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126808/">https://git.reviewboard.kde.org/r/126808/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On marts 6th, 2016, 3:01 a.m. EET, <b>Martin Tobias Holmedahl Sandsmark</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126808/diff/2/?file=445178#file445178line160" style="color: black; font-weight: bold; text-decoration: underline;">src/Application.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">120</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">m_parser</span><span class="p">.</span><span class="n">isSet</span><span class="p">(</span><span class="s">"close"</span><span class="p">))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The parser only seem to get a "noclose" option.</pre>
</blockquote>
<p>On aprīlis 8th, 2016, 10:17 p.m. EEST, <b>Martin Tobias Holmedahl Sandsmark</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have created an updated patch fixing the issues with the command line arguments: https://paste.kde.org/pbtppl8pc/iaa2xm/raw</p></pre>
</blockquote>
<p>On aprīlis 8th, 2016, 10:51 p.m. EEST, <b>Martin Tobias Holmedahl Sandsmark</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've been using the previous patch for a while, just updated it now to get rid of a warning about empty argument lists and a crash: https://paste.kde.org/pocjym2vy/caochh/raw</p></pre>
</blockquote>
<p>On aprīlis 9th, 2016, 2:24 p.m. EEST, <b>Martin Tobias Holmedahl Sandsmark</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">D?vis Mos?ns, if it is okay with you I'll open my own review request for my updated version of your patch here.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And sorry for the comment spam here, but for some reason the edit menu doesn't get populated anymore with these patches (both the original one in this review and mine).</p></pre>
</blockquote>
<p>On aprīlis 9th, 2016, 2:52 p.m. EEST, <b>Martin Tobias Holmedahl Sandsmark</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I had to update the check for whether the konsolepart was loaded in konsole itself because it is now using a normal QApplication, not a custom class: https://paste.kde.org/puocvbqlm</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yeah sure go ahead :)</p></pre>
<br />
<p>- Dāvis</p>
<br />
<p>On februāris 23rd, 2016, 9:21 p.m. EET, Dāvis Mosāns wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Dāvis Mosāns.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2016, 9:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Port away from KUniqueApplication, and from KCmdLineArgs to
QCommandLineParser. Remove KDELibs4Support dependency.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">compiles/builds and basic things seems to be working</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(c498aba89ed59333f2214f52e1b500ca9876233d)</span></li>
<li>src/Application.h <span style="color: grey">(b7389ef3d9a2d12a334fff00af3e2f9817d1289a)</span></li>
<li>src/Application.cpp <span style="color: grey">(326c766fb5ff8669bcbce6f2d4d72f8764681400)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(679807931585644000be0a38ccd67fe5158b3fa5)</span></li>
<li>src/MainWindow.h <span style="color: grey">(500b39561116ce4ce72fa7d3a742c5a57c2b49ef)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(822e45d57635dd7328eaec7db3eae41cdf19e61b)</span></li>
<li>src/SessionController.h <span style="color: grey">(02f51d9db679eb32d6403ee1103b40842b0c668e)</span></li>
<li>src/SessionListModel.cpp <span style="color: grey">(fb28bb806d270b019978684bfeb1052a83afea03)</span></li>
<li>src/autotests/PartTest.cpp <span style="color: grey">(b3e7797bd5c52ca5449996099275888936ae9528)</span></li>
<li>src/main.cpp <span style="color: grey">(5e1420e37363454cf5e7886a82381cb9eb4447d8)</span></li>
<li>src/settings/ProfileSettings.cpp <span style="color: grey">(d6dafbf17285192727679f92e91744e6c00b2c50)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126808/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>