<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124590/">https://git.reviewboard.kde.org/r/124590/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Konsole and Kurt Hindenburg.</div>
<div>By Lindsay Roberts.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">While Konsole's main scrollbar is handled by QtScrollBar and therefore works as expected under Qt5, the other custom scroll wheel actions available do not accumulate and handle the small scroll deltas provided. This results in stuttery, uneven and unexpected responses to scrolling.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Accumulate and trigger events on thresholds. If pixel scroll values are provided, utilise them when emulating mouseup/mousedown events (by dividing by pixel font height).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Based on a previous and outstanding review (https://git.reviewboard.kde.org/r/123389/) by Xuetian Weng.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested font size zoom, emulated cursor movement, regular scroll with and without QT_DEVICE_PIXEL_RATIO=2 set on linux with a high precision trackpad. Also tested with pixel scroll data hardcoded off to ensure we still support that style (if/where Qt5 still provides it).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(2ff6f37)</span></li>
<li>src/ScrollState.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ScrollState.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/TerminalDisplay.h <span style="color: grey">(c043803)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(1736aff)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124590/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>