<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120001/">https://git.reviewboard.kde.org/r/120001/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 12th, 2014, 12:55 a.m. UTC, <b>Mark Raymond</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hello - how long might it take for this review request to be looked at? I'm in no hurry - just interested to know :) Thanks!</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">usually it wouldn't take this long for me to look at - but I just moved frameworks to master branch - I have 4-6 patches to look at in the next week or so.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks</p></pre>
<br />
<p>- Kurt</p>
<br />
<p>On August 30th, 2014, 11:15 a.m. UTC, Mark Raymond wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Mark Raymond.</div>
<p style="color: grey;"><i>Updated Aug. 30, 2014, 11:15 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A couple of years ago, <a href="https://bugs.kde.org/show_bug.cgi?id=295648" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">bug 295648</a> was fixed, introducing support for <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">konsole -e "man ls"</code> in <a href="https://projects.kde.org/projects/kde/applications/konsole/repository/revisions/aa75fc8fee7e55e0c78640fcbed0bf0627ba7971" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">commit aa75fc8f</a>. However it introduced <a href="https://bugs.kde.org/show_bug.cgi?id=308553" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">bug 308553</a>, which meant that <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">konsole -e "path with spaces in.sh"</code> no longer worked, and so the fix was reverted in <a href="https://projects.kde.org/projects/kde/applications/konsole/repository/revisions/48b5575c174fb4edb6d3388d7a22dec148dea8cb" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">commit 48b5575c</a>.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch fixes <a href="https://bugs.kde.org/show_bug.cgi?id=295648" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">bug 295648</a> without reintroducing <a href="https://bugs.kde.org/show_bug.cgi?id=308553" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">bug 308553</a> by checking whether the first parameter exists before interpreting using ShellCommand.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">konsole -e man ls<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
konsole -e "man ls"</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">konsole -e /bin/sh ./geany_run_script.sh<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
konsole -e "/bin/sh ./geany_run_script.sh"</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">konsole -e "/home/mark/script with spaces.sh"<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
konsole -e /home/mark/script\ with\ spaces.sh</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Application.cpp <span style="color: grey">(0c4ae08a19c906b3939f3e77c2157f99c1d13fef)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120001/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>