<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117482/">https://git.reviewboard.kde.org/r/117482/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 12th, 2014, 3:23 a.m. CEST, <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
<p>On April 21st, 2014, 3:56 a.m. CEST, <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see from review 117478, there might be concerns about these changes - I have a good diff I can commit when it is decided all these changes are good.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, I am waiting for a conclusion on that review before committing anything</pre>
<br />
<p>- Alexander</p>
<br />
<p>On April 10th, 2014, 4:23 p.m. CEST, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated April 10, 2014, 4:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Convert to Qt5 signal slot syntax
This was done automatically with some minor adaptions using my clang based conversion tool
(https://github.com/a-richardson/convert2qt5signalslot)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles and starts (might also fix some bad connections)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Application.cpp <span style="color: grey">(c14edb90c93bb41af0033c7ddff5919a13830d7d)</span></li>
<li>src/ColorSchemeEditor.cpp <span style="color: grey">(9f029ab630dc9584e4d6cd72daa1e6b3abb1dd22)</span></li>
<li>src/CopyInputDialog.cpp <span style="color: grey">(619307b98a6a52c0611ee3b101cd9c9a60308171)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(f52d6dc4b4b6560391567fa63ad3fc7b5182834e)</span></li>
<li>src/Emulation.h <span style="color: grey">(52a34b4eeaee9eb71389f2987c5e84bf005d8bc2)</span></li>
<li>src/Emulation.cpp <span style="color: grey">(4363f571cde5d21c53c2d3b60907c5e78223c824)</span></li>
<li>src/Filter.h <span style="color: grey">(cbcc8e22d073ab8e435dba07a5488e797d0cf4f6)</span></li>
<li>src/Filter.cpp <span style="color: grey">(bb695fb3d0741c94eb3d3529249a33766f0583eb)</span></li>
<li>src/HistorySizeWidget.cpp <span style="color: grey">(f45608a322f10981adba9b677d939a734ba7efd4)</span></li>
<li>src/IncrementalSearchBar.cpp <span style="color: grey">(133c84438aef41b014ccfe128628f3a6f31084b1)</span></li>
<li>src/KeyBindingEditor.cpp <span style="color: grey">(c22bb4fc6ef31ffb5b429b1c7a8f9293201b711b)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(ea0b9796bee63674f1704f357ca010cbd14041f9)</span></li>
<li>src/ManageProfilesDialog.cpp <span style="color: grey">(a2887b611194aaed86815fb160a17e80dc96989f)</span></li>
<li>src/Part.cpp <span style="color: grey">(69f700a9e6ae316ba9cc621f012d3e74563f8f64)</span></li>
<li>src/ProfileList.cpp <span style="color: grey">(a393371c9feffcacbeb8cfb72571219626d55545)</span></li>
<li>src/Pty.h <span style="color: grey">(73b453610f51fad6f82902b58b90d1d180f9f303)</span></li>
<li>src/Pty.cpp <span style="color: grey">(dcff7e5b411e4b7528d8d771a45ff40ea71a096c)</span></li>
<li>src/RenameTabWidget.cpp <span style="color: grey">(873ebcf8b37ee7844de173435687478b7f03e4b4)</span></li>
<li>src/Session.h <span style="color: grey">(9e982df6dbe16e71c56c6cc9c98b93f04205d846)</span></li>
<li>src/Session.cpp <span style="color: grey">(cf0fc4d8edda0956a2f96499cb08fc08ba2a7cc6)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(5cd69ec364e1c8ec8a7b6406e4e0d8ca78385f03)</span></li>
<li>src/SessionListModel.cpp <span style="color: grey">(33af851f90dfa0494f7d6051203d2d91f79cc0da)</span></li>
<li>src/SessionManager.cpp <span style="color: grey">(1b80b75002516c699fd57b57625f93c7a0b22cfe)</span></li>
<li>src/TabTitleFormatButton.cpp <span style="color: grey">(7b85ffee02f59b6fa6c0e00e4a463811da97cd0d)</span></li>
<li>src/TerminalDisplay.h <span style="color: grey">(f0699e92b60b210d0d34d48aecb99b6405f8483a)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(e67b449a161ab4c5819749d22f8ff1f1b89eae47)</span></li>
<li>src/ViewContainer.cpp <span style="color: grey">(4acc0e3005e9d6a21527c2a48b41700cbd28df02)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(6485586bc6bdabde94a0b81a9463855a3dc744ec)</span></li>
<li>src/ViewSplitter.cpp <span style="color: grey">(ea043738d15b73b63d3e44b390d1e10271339415)</span></li>
<li>src/Vt102Emulation.h <span style="color: grey">(8d678e00b28b2d055e0f324367e0990a7c04e925)</span></li>
<li>src/Vt102Emulation.cpp <span style="color: grey">(33df23bbf346cd6ddbbe3dac39898d56944ea941)</span></li>
<li>src/ZModemDialog.cpp <span style="color: grey">(e5e7ce93353175bc8f2f01bb3a3240f3d51a4e74)</span></li>
<li>src/settings/GeneralSettings.cpp <span style="color: grey">(160a87a916e6fed3b56ea97ec9515e1485244763)</span></li>
<li>src/tests/PartManualTest.cpp <span style="color: grey">(957877b85dffb455247f90d52f925f6b47c816e0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117482/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>