<div dir="ltr">I think that the "multi-terminal" implementation is ready for some alpha-testing.<div><br></div><div>The general functionality (adding and removing multi-terminal splits) should work, but I expect bugs to be there and crashes to happen :D!</div>
<div><br></div><div>Further, I am quite sure that some of the existing functionality of konsole is broken (e.g., I just noticed that tabs are not detachable in my implementation and I will work to fix this problem). I think I can get a great help on identifying these broken parts from people that generate different use cases than the ones I do on my normal workflow.</div>
<div><br></div><div>The repository is at <a href="https://github.com/vincepii/konsole-multi-terminal" target="_blank">https://github.com/vincepii/konsole-multi-terminal</a> and I would propose to report issues there or directly to me. Suggestions on this point (how to handle development and bug reporting) are welcome.</div>
<div><br></div><div>What should be tested:</div><div>* Open multi-terminals from "View" --> "Multi Terminal" menu</div><div>* Delete multi-terminals</div><div>* Create and delete tabs</div><div>* Move between terminals on the same tab with ALT + <arrow keys></div>
<div>* ...</div><div><br></div><div>This should be clear, but I prefer to make it explicit: this code base is still unstable, do not use this version of konsole for anything important!</div><div><br></div><div>Thanks,</div>
<div>Vincenzo.</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">2014-01-23 22:15 GMT+01:00 Vincenzo Pii <span dir="ltr"><<a href="mailto:vinc.pii@gmail.com" target="_blank">vinc.pii@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im HOEnZb"><div dir="ltr"><span style="font-family:arial,sans-serif;font-size:13px">Hi,</span><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">
The review has been published and it is available here: <a href="https://git.reviewboard.kde.org/r/115275/" target="_blank">https://git.reviewboard.kde.org/r/115275/</a>.</div>
<div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">Please keep in mind that the work is still in progress: there are TODOs, debug code, garbage, hacks, ... So, do not waste too much time on the tiny particulars for the moment :D!</div>
<div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">General comments, suggestion for improvements, etc. are highly appreciated.</div></div></div><div class="HOEnZb">
<div class="h5"><div class="gmail_extra">
<br><br><div class="gmail_quote">2014/1/21 Kurt Hindenburg <span dir="ltr"><<a href="mailto:kurt.hindenburg@gmail.com" target="_blank">kurt.hindenburg@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">Hello,</div><div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
Putting it up on review board makes it easier for anyone to look at and comment on. </div><div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto"><br></div><div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
Thanks.</div><span><font color="#888888"> <div><span style="font-family:helvetica,arial;font-size:13px"></span>-- <br>Kurt Hindenburg<br><br></div></font></span><div><div> <br><p style="color:#a0a0a8">
On January 20, 2014 at 9:56:52 AM, Vincenzo Pii (<a href="mailto://vinc.pii@gmail.com" target="_blank">vinc.pii@gmail.com</a>) wrote:</p> <blockquote type="cite"><span><div><div>
<div dir="ltr">
<div>
<div>Hi Kurt,<br>
<br></div>
<div>If the goal of creating the review would be to submit my
changes, then I would say it's too early, quite some development is
still needed :).<br></div>
<div>If, on the other hand, the review would be a stepping stone to
move the work on the Konsole repo (maybe on a branch) and then
continue the development there, then I totally agree.<br>
<br></div>
</div>
<div>Vincenzo.<br></div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">2014/1/20 Kurt Hindenburg <span dir="ltr"><<a href="mailto:kurt.hindenburg@gmail.com" target="_blank">kurt.hindenburg@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
Thanks, if you can try to put up a patch on <a href="http://git.reviewboard.kde.org" target="_blank">git.reviewboard.kde.org</a> with group as Konsole. I
think “most” people don’t like the way the splitting is done now in
Konsole.</div>
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
Kurt</div>
<div>
<div>
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<br></div>
<div><span style="color:rgb(160,160,168)">On January 20, 2014 at
9:19:39 AM, Vincenzo Pii (</span><a href="mailto://vinc.pii@gmail.com" target="_blank">vinc.pii@gmail.com</a><span style="color:rgb(160,160,168)">) wrote:</span></div>
</div>
</div>
<blockquote type="cite">
<div>
<div>
<div>
<div>
<div dir="ltr">
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div><span>Hello everybody.<br>
<br></span></div>
<span>I am working on the implementation of a different kind of
"Split View" than the one which is already present in
Konsole.<br>
<br></span></div>
<span>This one behaves like the split function in the "Terminator"
application.<br>
<br></span></div>
<span>My intention is not to replace the "Split View", but to add a
new feature called "Multi Terminal".<br></span></div>
<span>They can coexist if you think that a multi terminal can be
opened inside a view which is already split (or the other way
around). Basically multi-terminals can be contained by Split
Views.<br>
<br></span></div>
<span>I am currently working on my own GitHub branch, on which I
push updates that I pull from the master konsole repo, plus the
local changes for the multi-terminal implementation.<br>
<br></span></div>
<span>The repo is located here: <a href="https://github.com/vincepii/konsole-multi-terminal" target="_blank">https://github.com/vincepii/konsole-multi-terminal</a>.<br>
</span></div>
<span>One of the files on the root dir is a screenshot that can
explain what I am trying to do.<br>
<br></span></div>
<span>There is also a bug report asking for this: <a href="https://bugs.kde.org/show_bug.cgi?id=178320" target="_blank">https://bugs.kde.org/show_bug.cgi?id=178320</a>.<br>
<br></span></div>
<span>The current working status is far from being finished.<br>
The main functionality is there however (create splits, close
them).<br>
<br></span></div>
<span>So, why am I writing this?<br></span></div>
<span>First of all to let the community know about this work: there
might be concerns or reasons for which this feature is not
wanted.<br>
<br></span></div>
<span>Secondly, but not less importantly, to ask you if there is a
more proper way for handling the development. I have to use a
different repo because I don't have rights on the kde one, so I
cannot just use a git branch.<br>
<br></span></div>
<span>Of course if someone wants to help, the source code is
there.<br>
<br></span></div>
<span>Regards,<br></span></div>
<span>Vincenzo.<br></span></div>
</div>
</div>
<span>_______________________________________________<br>
konsole-devel mailing list<br>
<a href="mailto:konsole-devel@kde.org" target="_blank">konsole-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/konsole-devel" target="_blank">https://mail.kde.org/mailman/listinfo/konsole-devel</a><br>
</span></div>
</div>
</blockquote>
</div>
</blockquote>
</div>
<br></div>
</div></div></span></blockquote></div></div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>