<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115628/">https://git.reviewboard.kde.org/r/115628/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Kurt Hindenburg.</div>
<p style="color: grey;"><i>Updated Feb. 15, 2014, 3:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=152385">152385</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Follow up to https://git.reviewboard.kde.org/r/103952/
Note this is not finished code (gui needs more work, etc) - I need to test and see if it actually works and if there are any issues still.
If anyone wants to review/commnet and/or test, please do so.
==
Remove profile setting - save geometry size on exit
Add Konsole setting - save geometry size on exit (nullifies profile settings)
Add Profile terminal col/row settings
If "save geometry", use kmainwindow settings, ignore profile col/row
If not "save geometry", remove kmainwindow settings, use profile col/row
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EditProfileDialog.h <span style="color: grey">(97adb93b7540fa971bb450bbabf3e5381a6a53c0)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(d43a89666693dfa767e21049df85ff86fded02c4)</span></li>
<li>src/EditProfileDialog.ui <span style="color: grey">(82298cfe0f554188f2983afe23e8c23bceeae3f6)</span></li>
<li>src/MainWindow.h <span style="color: grey">(33e0fda25612f5a27be55de0af61fb37c61501b1)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(6eccdf818c819432ab361a2565793dcfeef8e5b2)</span></li>
<li>src/Profile.h <span style="color: grey">(596f78acc2a570a904203a646f74b4f957d080be)</span></li>
<li>src/Profile.cpp <span style="color: grey">(14946ce69000eef00b03864e4610c6775597a51d)</span></li>
<li>src/ViewManager.h <span style="color: grey">(2a7f3483fcdbc1397b47df65ad8317df2215b33b)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(0b43bb88aee914a3d82965eb6349dc4938368704)</span></li>
<li>src/settings/GeneralSettings.cpp <span style="color: grey">(4a3786268fee953bbaab1b6ec300d6a607242bed)</span></li>
<li>src/settings/GeneralSettings.ui <span style="color: grey">(20b7a29d8855128a862b8b339055f2d9f30c61d0)</span></li>
<li>src/settings/konsole.kcfg <span style="color: grey">(dbe5ef55187dd226faa56c6c7c081c606e341158)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115628/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>