<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111937/">http://git.reviewboard.kde.org/r/111937/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111937/diff/3/?file=177421#file177421line7" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">7</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">find_package</span><span class="p">(</span><span class="s">ECM</span> <span class="s">0.0.8</span> <span class="s">REQUIRED</span> <span class="s">NO_MODULE</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please use 0.0.9</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111937/diff/3/?file=177421#file177421line19" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">19</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">find_package</span><span class="p">(</span><span class="s">LibAttica</span> <span class="s">REQUIRED</span> <span class="s">NO_MODULE</span> <span class="p">)</span> <span class="c">#somehow this is not searched for</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">/kde/src/kdebase/konsole (master) # git grep -i attica | wc -l
0
Why do you need libattica exactly ?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111937/diff/3/?file=177421#file177421line20" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">find_package</span><span class="p">(</span><span class="s">KDELibs4</span> <span class="s">REQUIRED</span> <span class="s">NO_MODULE</span><span class="p">)</span> <span class="c">#needed for KDE4Support</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please remove the REQUIRED keyword and use set_package_properties</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111937/diff/3/?file=177421#file177421line21" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">find_package</span><span class="p">(</span><span class="s">KDE4Support</span> <span class="s">REQUIRED</span> <span class="s">NO_MODULE</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">same here</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111937/diff/3/?file=177421#file177421line23" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">23</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">remove_definitions</span><span class="p">(</span><span class="s">-DQT_NO_SIGNALS_SLOTS_KEYWORDS</span> <span class="s">-DQT_NO_CAST_FROM_ASCII</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QT_NO_SIGNALS_SLOTS_KEYWORDS is not needed with ECM 0.0.9</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111937/diff/3/?file=177421#file177421line42" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">kde4_no_enable_final(konsole)</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">40</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="err">kde4_no_enable_final(konsole)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">could be moved into the else() section above</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111937/diff/3/?file=177421#file177421line45" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">include</span><span class="p">(</span><span class="s">FeatureSummary</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move this line between line 3 & 4 to use set_package_properties in your if(QT5_BUILD) section</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111937/diff/3/?file=177421#file177421line52" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">19</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">macro_display_feature_log</span><span class="p">()</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">50</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">feature_summary</span><span class="p">(</span><span class="s">WHAT</span> <span class="s">ALL</span> <span class="s">INCLUDE_QUIET_PACKAGES</span> <span class="s">FATAL_ON_MISSING_REQUIRED_PACKAGES</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using feature_summary unconditionnally means the KDE4 build requires kdelibs > 4.9.4. (ae4e7c131 in kdelibs is required in that case)
Please change the find_package(KDE4 ...) line above. Requiring kdelibs 4.10 is a wise choice since it also requires cmake > 2.8.6 (feature_summary doesn't exist in older versions)
</pre>
</div>
<br />
<p>- Christophe</p>
<br />
<p>On August 8th, 2013, 5:04 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2013, 5:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port to KF5/Qt5
It will build for KF5 automatically if Qt5 is found.
You can override this behaviour by using cmake -DFORCE_QT4=ON
TerminalDisplayAccessible is disable for Qt5 currently since I don't
have any experience with accessible stuff and it is complicated than
just changing a few includes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles fine (both Qt4 and Qt5).
After installation the terminal view of KF5 based okteta started working.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(5783804588bc4b1d1687e2dd1aaff76f3a65906e)</span></li>
<li>src/BookmarkHandler.h <span style="color: grey">(76c33269e5f20cbe20c97cfa621236cf05dc0f53)</span></li>
<li>src/BookmarkHandler.cpp <span style="color: grey">(9fc1600aa5a2901549f87295894acaf88b2f55ed)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(48601a147b4ba9a48eee064d9071382d6dd683b1)</span></li>
<li>src/ColorScheme.cpp <span style="color: grey">(6945c39144d12d8faefbb5242edfa1899e278477)</span></li>
<li>src/ColorSchemeEditor.cpp <span style="color: grey">(afe13c3a447197ff864639be3d6c136b146c8c66)</span></li>
<li>src/ColorSchemeManager.cpp <span style="color: grey">(802f5d7f9d3a1008a8785b27546a7ffa27fac24c)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(aff67b5723e2f1e08cf6aebc82f4911ffadc353e)</span></li>
<li>src/Emulation.cpp <span style="color: grey">(02ed4be48a5916c75c7731864b33b4a825c31e6e)</span></li>
<li>src/Filter.cpp <span style="color: grey">(8f40c0c598bd1f61ec2ad9765c2399d0ba011744)</span></li>
<li>src/KeyBindingEditor.cpp <span style="color: grey">(005b9e32027dd14f9965ec6e2e7dd32e94b79272)</span></li>
<li>src/KeyboardTranslator.h <span style="color: grey">(99c71743d6c295c14381a83787baa061e7703878)</span></li>
<li>src/KeyboardTranslator.cpp <span style="color: grey">(8fe2acb40d75b62595b9823a990ba99f0e6e0509)</span></li>
<li>src/KeyboardTranslatorManager.cpp <span style="color: grey">(4d46210517e901b14e379dcfe435fd8fdedaeb09)</span></li>
<li>src/MainWindow.h <span style="color: grey">(b297883eb9d62215ac71564b77c2145c1c8eeacc)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(285d6347be6680632b912b51961ced4d797a10bc)</span></li>
<li>src/Part.h <span style="color: grey">(2806bcdb066814ca32e1905772e99a0b2de426e5)</span></li>
<li>src/Part.cpp <span style="color: grey">(33e2d3849629e415817dc9a5f241e4ac3a323a28)</span></li>
<li>src/PrintOptions.cpp <span style="color: grey">(5e802987d5872f9041438a1ee69ec8162ddb962a)</span></li>
<li>src/Profile.cpp <span style="color: grey">(14946ce69000eef00b03864e4610c6775597a51d)</span></li>
<li>src/SessionController.h <span style="color: grey">(036e0534960fe7a1bd32be04136ba162c0469413)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(88fc50c6a164fed94eefc72a71e4460f15ede57e)</span></li>
<li>src/ShellCommand.cpp <span style="color: grey">(2b059a16e6232146cc9d75b1b6af25919fdcc4e7)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(acfddc176bc68ae9b0f3a9ea52c958e37d14dff8)</span></li>
<li>src/TerminalDisplayAccessible.h <span style="color: grey">(c6964412559e880dd27cf66a9fa8759196a09980)</span></li>
<li>src/TerminalDisplayAccessible.cpp <span style="color: grey">(8d37dc5e13448fc5d8619078c50334b0813597d4)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(4b9708e4a135a3682b319351ba02ce1d310c3329)</span></li>
<li>src/Vt102Emulation.cpp <span style="color: grey">(0b6d2ed2f75630df9fc7ac5d6d2b5d9a6702f254)</span></li>
<li>src/main.cpp <span style="color: grey">(2afc62c721b0e77264d0784caf7fbbd70b13951f)</span></li>
<li>src/tests/PartTest.cpp <span style="color: grey">(72cd27de07c0e96f8986db3a40dcf9239d9b3529)</span></li>
<li>src/tests/ShellCommandTest.cpp <span style="color: grey">(d03964fda57a1b37d4a02c82c3c04fd00040aaff)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111937/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>