<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110361/">http://git.reviewboard.kde.org/r/110361/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi thanks for working on this - as far as style, try not to include styles changes with code changes. So don't add/delete {}, lines, spaces/tabs that is not related to the new code.</pre>
<br />
<p>- Kurt</p>
<br />
<p>On May 8th, 2013, 2:09 p.m. UTC, renan fargetton wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By renan fargetton.</div>
<p style="color: grey;"><i>Updated May 8, 2013, 2:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The second half of the previous patch :
- add apply button
- try to fix the minor styling issues (but I may have forgotten some)
A remaining issue with the dialog is that it currently stop the application workflow : konsole terminal is frozen until the dialog close (i.e. exec() vs show() ). I would like to make this dialog non modal. I started working on it, and will submit a patch when its ready.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compile / run</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ColorSchemeEditor.h <span style="color: grey">(9b1e4b2)</span></li>
<li>src/ColorSchemeEditor.cpp <span style="color: grey">(421f613)</span></li>
<li>src/EditProfileDialog.h <span style="color: grey">(33b3930)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(74b0237)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110361/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>