<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107640/">http://git.reviewboard.kde.org/r/107640/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit c45d07698fc68522e94c082e638156a9ef94a438 by Francesco Cecconi to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 13th, 2013, 10:15 a.m. UTC, Francesco Cecconi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Francesco Cecconi.</div>
<p style="color: grey;"><i>Updated March 13, 2013, 10:15 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looking at the code, the best solution for the issue described in the bug is:
Fixing the wrong behaviour to open two or more "edit dialog" for one session/tab with
the same profile (it should be fixed anyway and this is the issue of the bug 311270 ),
and the crash with two or more "edit dialog", one for different session(tabs)
with the same profile.
With the patch:
one tab/session -> only one edit profile dialog at the same time ( 311270 )
tab1/session -> edit profile (profile1)
tab2/session -> edit profile (profile1)
...
tab[i]/session -> edit profile (profile1)
many tab with the same profile, only one edit dialog is shown
NOTE:The issue(crash) appears only when transparency property is modified by one of the two profiles.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=311270">311270</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/TerminalDisplay.cpp <span style="color: grey">(8016c1e)</span></li>
<li>src/TerminalDisplay.h <span style="color: grey">(46058be)</span></li>
<li>src/SessionController.h <span style="color: grey">(97020fa)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(25eb1ef)</span></li>
<li>src/ManageProfilesDialog.cpp <span style="color: grey">(3b270dc)</span></li>
<li>src/EditProfileDialog.h <span style="color: grey">(30d72e5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107640/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>