<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109130/">http://git.reviewboard.kde.org/r/109130/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit b2adf8d01619b94b93cde32fdae827f6c04fc6e4 by Kurt Hindenburg to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On February 24th, 2013, 8:35 p.m. UTC, Lindsay Roberts wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Lindsay Roberts.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2013, 8:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently the presence of the search bar is maintained per-tab, but the search
term itself is per-window. This leads to curiously inconsistent behaviour.
I believe there is little to suggest search terms remain relevant across
different tabs, and there is significant user expectation that search terms
(and the presence of the bar itself) are constrained to a tab (see browsers).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Loads of tab-switchin' and searchin'.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/IncrementalSearchBar.h <span style="color: grey">(e8153d6)</span></li>
<li>src/IncrementalSearchBar.cpp <span style="color: grey">(c8c5b0c)</span></li>
<li>src/SessionController.h <span style="color: grey">(390cc01)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(d310a50)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109130/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>