<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108844/">http://git.reviewboard.kde.org/r/108844/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 10th, 2013, 6:54 p.m. UTC, <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looks OK to me - do you have a KDE account to submit this?
The only suggestion I have is to name the patch something reasonable (instead of ksdiff) - like konsole_add_italic.diff or such</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oops--- sorry, I didn't realize the filename was preserved. Should I re-upload it?
I don't have developer access, and don't really see it as justified at the moment, so if you could submit it I would be grateful.</pre>
<br />
<p>- Jem</p>
<br />
<p>On February 8th, 2013, 12:29 a.m. UTC, Jem Orgun wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jem Orgun.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2013, 12:29 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds support for escape sequences \e[3m and \e[23m (to turn italics on and off respectively). I have no idea if this is actually a standard, but it's listed on Wikipedia, (http://en.wikipedia.org/wiki/ANSI_escape_code#CSI_codes), implemented in urxvt, and used by vim, so evidently it has some grounding.
This is my first time doing this, so if I'm doing something wrong please tell me.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">` echo -e "\e[1mbold\e[22m \e[3mitalic\e[23m \e[4munderline\e[24m \e[5mblink\e[25m \e[7mreverse\e[27m" ' works as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Character.h <span style="color: grey">(ced1621)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(d14daba)</span></li>
<li>src/Vt102Emulation.cpp <span style="color: grey">(1ab7758)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108844/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>