<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108461/">http://git.reviewboard.kde.org/r/108461/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm confused.
Isn't the newest patch again or still making libkonq one automagic dependency ?
We need to allow packagers/users to explicit disable the libkonq feature with something like "cmake -DUSE_LIBKONQ=off ..", even when libkonq is available in the building environment.
Beside that, the patch doesn't seem to work correctly. I just type "cmake .. ; make; make install" , then libkonq is detected, libkonsoleprivate.so linked to libkonq, but the feature is actually not built into.
"if defined(LIBKONQ_FOUND)", err, LIBKONQ_FOUND is known to cmake, but not known to the compiler.</pre>
<br />
<p>- Jekyll</p>
<br />
<p>On January 22nd, 2013, 2:37 p.m. UTC, Kurt Hindenburg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Kurt Hindenburg.</div>
<p style="color: grey;"><i>Updated Jan. 22, 2013, 2:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I meant to do this earlier - this change allows konsole to build w/o libKonq - I've come across system w/o the libKonq installed. You look the dnd menus w/o libKonq.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(7829e13)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(a2c5621)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108461/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>