<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107640/">http://git.reviewboard.kde.org/r/107640/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Francesco Cecconi.</div>
<p style="color: grey;"><i>Updated Dec. 9, 2012, 10:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">update description</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looking at the code, I have two solutions (or simple reflections :) for the issue described in the bug.
First
Making "edit profile dialog" a modal dialog, but this limits the possibility to change
more profiles(one for session) without closing the first one.
Second
Fixing the wrong behaviour to open two or more "edit dialogs" for one session/tab with
the same profile (it should be fixed anyway and this is the issue of the bug 311270 ),
and the crash with two or more "edit dialog", one for different session(tabs)
with the same profile.
Fixed
one tab/session -> only one edit profile dialog at the same time ( 311270 )
tab1/session -> edit profile (profile1)
tab2/session -> edit profile (profile1)
...
tab[i]/session -> edit profile (profile1)
many tab with the same profile, only one edit dialog is shown
NOTE:The issue(crash) appears only when transparency property is modified by one of the two profiles.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=311270">311270</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EditProfileDialog.h <span style="color: grey">(c85bd11)</span></li>
<li>src/SessionController.h <span style="color: grey">(aefdbc6)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(fd58ecc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107640/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>