<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107086/">http://git.reviewboard.kde.org/r/107086/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 12th, 2012, 9:32 p.m., <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107086/diff/2/?file=93060#file93060line8" style="color: black; font-weight: bold; text-decoration: underline;">desktop/run-in-konsole.desktop</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">8</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Terminal=false</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I mean:
Exec=%f
Terminal=true
This will run %f in a terminal, won't it?</pre>
</blockquote>
<p>On November 13th, 2012, 6:14 a.m., <b>Jekyll Wu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, I see.
I think that should work. But strangely it doesn't work as expected. No matter which emulator(xterm,urxvt,etc) I have chosen as the default emulator, it is always konsole that is started to provide a running environment. "Shift+F4" in dolphin opens the chosen emulator, as expected.
And even for that konsole case, it is invoked like "konsole -e /some/script.sh" without the "--hold" option. I think that "--hold" option is very important for the suggested use case. I don't want to the terminal window to suddenly disappear the moment the script finishes its job.
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Even after restarting KDE (or at least dolphin)? Maybe KRun just didn't reparse the configuration file after you changed the setting.
That code could also add --hold to the command line when the chosen terminal is konsole.
kdelibs/kio/kio/krun.cpp: 501: QString terminal = cg.readPathEntry("TerminalApplication", "konsole");
The question is whether any user configuring a .desktop file Terminal=true would like the terminal to stay open after the app exits. For scripts yes, for GUI apps, maybe this isn't actually wanted....
Well, if you think that it's not wanted for gui apps, then indeed don't use Terminal=true, but your current patch.</pre>
<br />
<p>- David</p>
<br />
<p>On November 11th, 2012, 7:56 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Dolphin, Konsole and David Faure.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Nov. 11, 2012, 7:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@David, I'd like to know your idea of this workaround, because I think its usefulness will influence or be influenced by how bug 275405 will be finally resolved.
The current situation of clicking an executable shell script in dolphin/konqueror:
1. It is always executed, instead of being opened by the preferred application according to its mimetype. (bug 275405)
2. It is executed in a silent way, without invoking konsole to provide a running environment (bug 225563). That means at least two issues:
a). There is no feedback and no easy way for user to know whether that script has been started. He/She need use ps or ksysguard to verify it.
b). interactive script just doesn't work.
This patch *doesn't* really solve any of the above two problems. It just provides the possibility for users to run an executable script in konsole when using dolphin/konqueror.
It adds two .desktop files:
applications/kde4/run-in-konsole.desktop, which can be used in the "Open with" submenu
ServiceMenus/konsolerun.deksotp, which can be used in the "Actions" submenu
I'm not sure which solution is better, so I just provide both :)
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=225563">225563</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=275405">275405</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktop/CMakeLists.txt <span style="color: grey">(0fe39d2)</span></li>
<li>desktop/konsolerun.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>desktop/run-in-konsole.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107086/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>