<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106720/">http://git.reviewboard.kde.org/r/106720/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 6th, 2012, 4:47 p.m., <b>Jekyll Wu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, I tend to differ from your opinion.
First, kate/kwrite/kdevelop are actually just about katepart. If you take some other KDE applications(rekonq, okular, calligra words, etc) into account, konsole is consistent with them. Another important difference between konsole and katepart is konsole highlight all matches and katepart seems to only highlight the current match.
Second, I can think of at least one use case where the suggested behavior would be really annoying, based upon my daily usage.
Use case:
I'm trying to find some information in a very long debug output. I search the scrollback using the keyword, say, "usb", because I only know the needed information should appear somewhere between two lines containing "usb". And it turns out the distance between that two "usb" lines is 3 pages/screens. That means I need to scroll between those 3 pages line by line and look for the needed information .
With current behavior, that is an easy task. After searching for "usb", I just use mouse to click the terminal area, and press "Shift+Up/Down" for scrolling line by line. I don't need to worry about scrolling beyond the other "usb" line ,because "usb"s are still highlighted and they serve as nice markers .
With the proposed new behavior, I am lost because those nice markers are gone the moment I click the terminal area. I have no idea whether I have scrolled too much, unless I check whether I have reached the other "usb" line by reading each line word by word. That is clearly less efficient.
Yes, I can use scrollbar to avoid the highlight disappearing, but I am dealing with a very long debug output and I need to scroll line by line between 3 pages. Scrollbar just scrolls too much and thus useless in this case.
</pre>
</blockquote>
<p>On October 8th, 2012, 10:09 a.m., <b>Francesco Cecconi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for your time Jekyll.
> katepart seems to only highlight the current match
katepart highlight all matches, but the search match rules are different.
"hello hello hellodsajdosijdoiadjas" [search: hello] it matches only the first two occurrences
> Second, I can think of at least one use case where the suggested behavior would be really annoying, based upon my daily usage.
I could insert a modifier (e.g. ctrl + left click), for my usage case, to keep both modes.</pre>
</blockquote>
<p>On October 10th, 2012, 12:44 p.m., <b>Francesco Cecconi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">sorry but I have forgotten to mention that katepart "Highlight selection" plugin must be activated</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well I don't have an opinion either way - Jekyll, do you have any thoughts on it as-is?</pre>
<br />
<p>- Kurt</p>
<br />
<p>On November 1st, 2012, 10:14 a.m., Francesco Cecconi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Francesco Cecconi.</div>
<p style="color: grey;"><i>Updated Nov. 1, 2012, 10:14 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After a search, when an user press 'ctrl + left mouse button' on the konsole view,
remaining filters (highlight/*) are removed.
This patch will make possible continue "normal work" (without active search filters) and search, without
having to open and close, every time, the search bar. (compliant with kate/kwrite/kdevelop....)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm using this path from long time ago.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/SessionController.h <span style="color: grey">(b41cc8e)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(9ee8899)</span></li>
<li>src/TerminalDisplay.h <span style="color: grey">(8e246b8)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(871dc9f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106720/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>