<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107281/">http://git.reviewboard.kde.org/r/107281/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good catch!
Some trivial things to do/know before pushing it :
1. the tokenize function is also called in another place (just a few lines below the line this patch modifies). For consistency, also change that line .
2. (optional). Open a bug on bugs.kde.org, describe the problem with a simple test case, like:
cp /usr/share/apps/konsole/default.keytab ~/.kde4/share/apps/konsole/test.keytab
edit test.keytab and change the line "keyboard ...." into "keyboard 中文测试"
restart konsole and a new keyboard layout is displayed with corrupted name "?????" (screenshot)
Then use commit hooks "BUG:<number>" and "FIXED-IN: 4.9.4" in your commit message to close that bug. That way we can easily track what is broken and has been and fixed in each version.
3. The konsole git repository follows the "first fix in master, then cherry-pick into stable if appropriate" model. So please first fix it in the master, then cherry-pick the commit into KDE/4.9 .
</pre>
<br />
<p>- Jekyll</p>
<br />
<p>On November 10th, 2012, 8:02 p.m., Yichao Yu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Yichao Yu.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2012, 8:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The built-in behavior of Ctrl+<Mouse Wheel> to zoom in/out the terminal is annoy sometimes and cannot be disabled. This patch adds an option to disable this behavior. (Default to the original behavior).
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled, installed.
Default is not affected.
After disabled the option, Ctrl+<Mouse Wheel> will not cause terminal zooming and the zooming is back after re-enabled it.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EditProfileDialog.h <span style="color: grey">(c85bd11)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(8e44df6)</span></li>
<li>src/EditProfileDialog.ui <span style="color: grey">(45eafcc)</span></li>
<li>src/Profile.h <span style="color: grey">(f14d3a2)</span></li>
<li>src/Profile.cpp <span style="color: grey">(e81433f)</span></li>
<li>src/TerminalDisplay.h <span style="color: grey">(8e246b8)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(871dc9f)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(faa1395)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107281/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>