<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107086/">http://git.reviewboard.kde.org/r/107086/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Jekyll, just a quick note to let you know that I appreciate any improvements in this area! I've been hit by this issue quite a few times myself when I clicked shell scripts or Python scripts and wondered what they did in the end. Being able to open them in a Konsole would definitely be an improvement.
There is bug 172038 which is about showing a dialog when clicking a script ("Run/Run in Konsole/Edit/Cancel"), just like Nautilus does. I don't know how this could be implemented in a clean way, but I like the idea. At least if there was also a "Don't ask again" checkbox in the dialog and the possibility to change that choice in the settings.
</pre>
<br />
<p>- Frank</p>
<br />
<p>On October 28th, 2012, 12:10 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Dolphin, Konsole and David Faure.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Oct. 28, 2012, 12:10 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@David, I'd like to know your idea of this workaround, because I think its usefulness will influence or be influenced by how bug 275405 will be finally resolved.
The current situation of clicking an executable shell script in dolphin/konqueror:
1. It is always executed, instead of being opened by the preferred application according to its mimetype. (bug 275405)
2. It is executed in a silent way, without invoking konsole to provide a running environment (bug 225563). That means at least two issues:
a). There is no feedback and no easy way for user to know whether that script has been started. He/She need use ps or ksysguard to verify it.
b). interactive script just doesn't work.
This patch *doesn't* really solve any of the above two problems. It just provides the possibility for users to run an executable script in konsole when using dolphin/konqueror.
It adds two .desktop files:
applications/kde4/run-in-konsole.desktop, which can be used in the "Open with" submenu
ServiceMenus/konsolerun.deksotp, which can be used in the "Actions" submenu
I'm not sure which solution is better, so I just provide both :)
Known issue:
using application/x-shellscript means this workaround only applies to shell scripts, so it does not provide help for perl/python scripts. But using applicaiton/x-executable means it will also apply to binary executables. So :
* Does it make sense to provide that workaround for binary executable? It is of course valid, but might be seen as overkill and strange in practice.
* Is there something called application/x-executablescript, that falls between the range of x-executable and x-shellscripts ?
* Should application/x-desktop be also added into "MimeType"?
As you see, this patch in the current form is still a rough idea.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=225563">225563</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=275405">275405</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktop/CMakeLists.txt <span style="color: grey">(0fe39d2)</span></li>
<li>desktop/konsolerun.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>desktop/run-in-konsole.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107086/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>