<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106129/">http://git.reviewboard.kde.org/r/106129/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 659d2c60aeeec00159074f14542737c4f26fe063 by Jekyll Wu to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On October 4th, 2012, 10:50 a.m., Vadim Zhukov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole and Jekyll Wu.</div>
<div>By Vadim Zhukov.</div>
<p style="color: grey;"><i>Updated Oct. 4, 2012, 10:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ATM Konsole does not support gathering process information on OpenBSD. I've a patch adding such support.
The first idea was to extend already existing FreeBSDProcessInfo class. I renamed it to a BSDProcessInfo and added a few #ifs here and there. After some input I've created separate OpenBSDProcessInfo class based on FreeBSDProcessInfo code.
I've also fixed a few nits regarding calling C routines (prepended "::" to sysctl() and such; added kWarning() printouts if they fail) in new code. If needed I can do them as a separate diff.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On OpenBSD-CURRENT.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ProcessInfo.cpp <span style="color: grey">(32c86b1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106129/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>