<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105796/">http://git.reviewboard.kde.org/r/105796/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 1st, 2012, 1:12 p.m., <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> as Konsole has to have integer sizes
Sorry, this is nonsense.
You are confusing pixel metrics, and font point sizes.
Much work has been put into KDE and Konsole to make it respect fractional point sizes, while still forcing integer metrics, and this commit basically destroys this work.
Please update the patch to allow (at least) one decimal for the point size.</pre>
</blockquote>
<p>On August 4th, 2012, 2:53 p.m., <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm still looking at this. I don't see any other terminal app allowing .x point sizes and I don't see the use case. I don't really have an issue with putting the .x back in.
I guess I don't quite understand this "respect fractional point sizes, while still forcing integer metrics,"</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The following explanation is simpified for understanding:
1 in (inch) = 2.54 cm = 72 pt (typographical points).
Let's say my display has a resolution of 159 ppi (pixels per inch). We compute:
- a font pt size of 16 pt means a pixel size of (16 / 72 * 159) = 35,33 pixels
- a font pt size of 17 pt means a pixel size of (17 / 72 * 159) = 37,54 pixels
Forcing integer metrics will round the pixel sizes to 35 or 38 pixels. When I want a pixel size of 36 or 37 pixels, I am screwed when I cannot select fractional point sizes.
The actual consequences are more complex, because it also affects freetype hinting.
In practise this means in Konsole on my system I have to select a font point size of 6.3 pt for optimal viewing pleasure. Making it smaller or larger looks worse. And I made patches to support fractional point sizes for KDE, Dolphin, and Konsole exactly because of this.
</pre>
<br />
<p>- Christoph</p>
<br />
<p>On July 30th, 2012, 2:50 p.m., Kurt Hindenburg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Kurt Hindenburg.</div>
<p style="color: grey;"><i>Updated July 30, 2012, 2:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure why a slider was used for the font size. And why fractions were allowed as Konsole has to have integer sizes.
If we really want a slider, kintnuminput has the option to add it as well.
I also removed the "size :" from the preview label as I was looking at bko 174998.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EditProfileDialog.ui <span style="color: grey">(be3e672)</span></li>
<li>src/EditProfileDialog.h <span style="color: grey">(4715ec5)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(68d5729)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105796/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>