<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105282/">http://git.reviewboard.kde.org/r/105282/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 12th, 2012, 2:35 p.m., <b>Jekyll Wu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think it is OK to go except some small issues.
If you already have a developer account, please fix those issues and commit it to the master branch (remember use the "REVIEW:<id>" hook in the commit message to automatically close this review ). If not, I will do it for you.
</pre>
</blockquote>
<p>On July 13th, 2012, 2:38 p.m., <b>Asko Eronen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm afraid I don't have a developer account.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, then I will do it.</pre>
<br />
<p>- Jekyll</p>
<br />
<p>On July 10th, 2012, 6:23 p.m., Asko Eronen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Asko Eronen.</div>
<p style="color: grey;"><i>Updated July 10, 2012, 6:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added optional feature in konsole, which allows opening links with single mouse click.
By default, the option is disabled. It can be enabled from profile manager -> Mouse -> "Mouse Click opens links"</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with simple terminal usage using gentoo package manager, irssi and htop. No problems ocured with them.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EditProfileDialog.h <span style="color: grey">(f9e35e6)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(678636e)</span></li>
<li>src/EditProfileDialog.ui <span style="color: grey">(e4196de)</span></li>
<li>src/Profile.h <span style="color: grey">(10a71b6)</span></li>
<li>src/Profile.cpp <span style="color: grey">(aded720)</span></li>
<li>src/TerminalDisplay.h <span style="color: grey">(8d91ddb)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(6a47299)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(0d01aae)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105282/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>