<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105423/">http://git.reviewboard.kde.org/r/105423/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 5th, 2012, 2:59 p.m., <b>Jekyll Wu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105423/diff/1/?file=71111#file71111line769" style="color: black; font-weight: bold; text-decoration: underline;">src/TerminalDisplay.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">private:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">769</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">bool</span> <span class="n">_c<span class="hl">tr</span>lDrag</span><span class="p">;</span> <span class="c1">// require Ctrl key for drag selected text</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">769</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">bool</span> <span class="n">_c<span class="hl">ontro</span>lDrag</span><span class="p">;</span> <span class="c1">// require Ctrl key for drag selected text</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">well, _controlDrag is no better than _ctrlDrag.
If renaming is really needed, I think _ctrlRequiredForDrag or something like that would be better. </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't know that renaming is strictly needed, but I think your suggestion is definitely better than either what's there now or my change, so I've incorporated it in my patch.</pre>
<br />
<p>- Scott</p>
<br />
<p>On July 5th, 2012, 1:28 p.m., Scott Kitterman wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole and Kurt Hindenburg.</div>
<div>By Scott Kitterman.</div>
<p style="color: grey;"><i>Updated July 5, 2012, 1:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Description: Add setting for control drag
Both KDE 3 and KDE 4.7 and 4.8 default to requiring click and control to drag
test in konsole. This was not required in KDE 4.0 - 4.6 and some people
prefer each method. At the moment, changing this requires recompiling
konsole, which is suboptimal. This patch adds a selection option in
the profile configuration options to change this at run time.
Addresses complaints about the fix in https://bugs.kde.org/show_bug.cgi?id=165923.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The most recent KDE I have running is 4.8.4. I first developed this patch for 4.8.4, compiled it and verified click/drag worked either with or without control based on the setting. The code required minimal adaptation to bring it up to trunk.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=165923">165923</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EditProfileDialog.h <span style="color: grey">(2345925)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(f5cfa8c)</span></li>
<li>src/EditProfileDialog.ui <span style="color: grey">(8b8e83c)</span></li>
<li>src/Profile.h <span style="color: grey">(83616c4)</span></li>
<li>src/Profile.cpp <span style="color: grey">(67cd80e)</span></li>
<li>src/TerminalDisplay.h <span style="color: grey">(c6e5972)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(112925f)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(92ab0b1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105423/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105423/s/613/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/03/konsolepic1_400x100.jpeg" style="border: 1px black solid;" alt="Designer Screenshot with master" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>