<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105423/">http://git.reviewboard.kde.org/r/105423/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Scott Kitterman.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Description: Add advanced setting for control drag
Both KDE 3 and KDE 4.7 and 4.8 default to requiring click and control to drag
test in konsole. This was not required in KDE 4.0 - 4.6 and some people
prefer each method. At the moment, changing this requires recompiling
konsole, which is suboptimal. This patch adds a selection option in
the profile configuration options to change this at run time.
Addresses complaints about the fix in https://bugs.kde.org/show_bug.cgi?id=165923.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The most recent KDE I have running is 4.8.4. I first developed this patch for 4.8.4, compiled it and verified click/drag worked either with or without control based on the setting. The code required minimal adaptation to bring it up to trunk.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=165923">165923</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EditProfileDialog.h <span style="color: grey">(2345925)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(f5cfa8c)</span></li>
<li>src/EditProfileDialog.ui <span style="color: grey">(8b8e83c)</span></li>
<li>src/Profile.h <span style="color: grey">(83616c4)</span></li>
<li>src/Profile.cpp <span style="color: grey">(67cd80e)</span></li>
<li>src/TerminalDisplay.h <span style="color: grey">(c6e5972)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(112925f)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(92ab0b1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105423/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>