<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104717/">http://git.reviewboard.kde.org/r/104717/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 4th, 2012, 3:08 p.m., <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With this patch and following the steps in bko, I get this assert when I finish the d-n-d.
ASSERT: "containers().contains(container)" in file /mnt/kde/kde4/trunk/src/konsole/src/ViewSplitter.cpp, line 126
</pre>
</blockquote>
<p>On May 4th, 2012, 5:45 p.m., <b>Francesco Cecconi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the test Kurt.</pre>
</blockquote>
<p>On June 18th, 2012, 1:10 p.m., <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Francesco, have you had anytime to look at this further?</pre>
</blockquote>
<p>On June 19th, 2012, 5:48 p.m., <b>Francesco Cecconi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Kurt,
sorry but at moment i haven't much spare time and the portion of code
relative to the issue is changed in the master branch.
however, on the next week I would like to start the work on the new patch.
Francesco</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The new patch is ready, this should remove the issue with the assert and disable the "split menu" correctly.
I've tested the patch with d-n-d and with a single window (no detach tab).</pre>
<br />
<p>- Francesco</p>
<br />
<p>On June 25th, 2012, 9:29 p.m., Francesco Cecconi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Francesco Cecconi.</div>
<p style="color: grey;"><i>Updated June 25, 2012, 9:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">automatically close blank split, after that last tab is moved.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- one tab + split + one tab -> move split right/left, no blank area
- from bug: after step 4 no blank area
seems to work well but more test are necessary. ;)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=275771">275771</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ViewContainer.h <span style="color: grey">(d5bdf73)</span></li>
<li>src/ViewContainer.cpp <span style="color: grey">(980c130)</span></li>
<li>src/ViewContainerTabBar.h <span style="color: grey">(5b97abc)</span></li>
<li>src/ViewContainerTabBar.cpp <span style="color: grey">(29805f3)</span></li>
<li>src/ViewManager.h <span style="color: grey">(7d1079e)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(40ed915)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104717/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>