<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105325/">http://git.reviewboard.kde.org/r/105325/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Alexander Sulfrian.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review contains three patches. I do not know how to submit them as separate
patches for one review. I attached the single patches as files to the review.
- protect control characters from deletion
If you remove characters from a line (replace with space) and first
character, that should be removed, is the first character with a new
color, do not remove the color but replace the character.
- save color on change
If the colors change, you need to save it in the next character to be
able to complete the line with the correct colors.
- keep color for additional character at line end
If the current line contains less characters than the width of the
current window, default chars were used to draw the additional
characters. This results in transparent (missing) line endings in some
ncurses applications, that draw lines using the background of space
characters. This keeps the color of the last character to draw the
missing chars.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Character.h <span style="color: grey">(d7afa148e2c64c75af035a3d073ea8f4d2bd9130)</span></li>
<li>src/Screen.cpp <span style="color: grey">(3d8944c5b22b553765256f53e33cae42cd518bba)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105325/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>