<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105155/">http://git.reviewboard.kde.org/r/105155/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks OK to me - I agree that 'test' is not really valid - perhaps change to example? Since this is docs/example it should be able to go into the 4.8 kdelibs. You'd should add kdelibs and/or ask in #kde-devel.</pre>
<br />
<p>- Kurt</p>
<br />
<p>On June 5th, 2012, 11:19 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated June 5, 2012, 11:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">main change:
1. update the outdated inline document for kde_terminal_interface(which contains some signals that does not exist ever since KDE 4.0)
2. update the example code to make it really work and avoid using hardcoded library name 'libkonsolepart'.
3. update test/CMakeList.txt to make it stand-alone. I don't think that 'test' subfolder is ever used for building test case. Maybe it is more accurate to rename that folder to 'example'. But I could be wrong.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The sample code works fine with kdelibs/4.8 and konsole built from master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=257350">257350</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/terminal/kde_terminal_interface.h <span style="color: grey">(649d674)</span></li>
<li>interfaces/terminal/test/CMakeLists.txt <span style="color: grey">(a0fa93a)</span></li>
<li>interfaces/terminal/test/main.h <span style="color: grey">(8a3197a)</span></li>
<li>interfaces/terminal/test/main.cc <span style="color: grey">(132cee1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105155/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>