<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104933/">http://git.reviewboard.kde.org/r/104933/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for this one-liner patch.
"I failed to implement the following: drag a tab from an instance of konsole A and drop to an instance of konsole B."
I guess 'instance' here means process instead of window, since konsole already supports dragging tab between windows as long as those windows belong to the same process. Dragging tab between different konsole processes is practically impossible. So not a issue.
There is a minor issue with that simple else clause. If there is only one tab in the current tabbar , dragging that tab out would trigger the detach, which feels unnecessary and unnatural. I think an extra check for the existing tab number would be better, like this :
if( _tabBar.count() > 1 )
emit detachTab(this, view);
</pre>
<br />
<p>- Jekyll</p>
<br />
<p>On May 13th, 2012, 8:25 p.m., makis marimpis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By makis marimpis.</div>
<p style="color: grey;"><i>Updated May 13, 2012, 8:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">An one-liner patch :}
Allows the user to tear out the tabs (with drag and drop).
I failed to implement the following: drag a tab from an instance of konsole A and drop to an instance of konsole B.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, seems to work fine.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=56749">56749</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ViewContainer.cpp <span style="color: grey">(1a0148e9e2e4185a2f8356b83b0bc971f4e8ce52)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104933/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>