<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104605/">http://git.reviewboard.kde.org/r/104605/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 17th, 2012, 12:45 p.m., <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">GO ahead - I would agree that the color boldness should be to only one - I think the profile one was an easy to find option for users.</pre>
</blockquote>
<p>On April 17th, 2012, 5:41 p.m., <b>Jekyll Wu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, if you also think this per-color-bold(heritage from the KDE3 era?) is not that useful or does not make sense anymore, then I think the better choice is to remove this hidden feature.
And if applying this patch, there is another thing to consider:
* "Bold=false" does not work before, while it works now(forcing using normal font weight).
* "Bold=false" entries are alreayd used in some colorschemes, like Linux, GreenOnBlack, etc
* That means uses who use the Linux colorsheme would find that they can't have bold text anymore(because Bold=false works now).
* To avoid that problem, we need to not only remove existing "Bold=false" entries from konsole repository, but also write some kconf-update script to remove existing "Bold=false" entries from users' konsole data folder.
I'm opt to remove that per-color-bold control, because the per-profile "BoldIntense" option should be enough.
</pre>
</blockquote>
<p>On April 19th, 2012, 12:50 p.m., <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm beginning to think you're correct. Having the hand-edited colorscheme Bold= never really seemed like a good idea.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, that "Bold=" key can be used to achieve some interesting results. For example, we can mark all normal colors as "Bold=true" and all intense colors as "Bold=false", which effectively inverts the bold/normal semantic.
But yes, it is not that intuitive to put something controlling boldness into colorscheme.
</pre>
<br />
<p>- Jekyll</p>
<br />
<p>On April 15th, 2012, 11:35 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated April 15, 2012, 11:35 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tha patch is trivial. Konsole now supports "Bold=true", "Bold=false" and other values(which all mean using Character::UseCurrentFormat).
However, I just wonder how useful this per-color boldness controlling could be. We already have the "BoldIntense" per-profile option to enable or disable boldness. Do we need two levels of boldness control: per-profile and per-color in each colorscheme?
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=168300">168300</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ColorScheme.cpp <span style="color: grey">(1acb4d4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104605/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>