<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104512/">http://git.reviewboard.kde.org/r/104512/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 9th, 2012, 6:15 a.m., <b>Jekyll Wu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, the implementaion of scollback history is still like black magic to me, so do not take my comments too serious :)
For the first issue of moving line index and isWrapped into memory, is there some real and nice benefit ? I mean moving them into memory does reduce the number of files on the disk, but the introduced inconsistency(some one disk, some in memory ) feels uneasy, especially when something goes wrong and we need to debug the code and data.
For the second issue of stop using map(), I think it is actually used now . For example, run "for i in $(seq 100); do dmesg; done" to generate enough scrollback, then press "Shift+Home" to jump to the very beginning, that map() will be called.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the feedback. writes are slightly faster. When I last checked I thought only the index file used map().
At some time it would be nice to handle errors such as the "tmp" HD being full. As it is , it is not easy to do that.</pre>
<br />
<p>- Kurt</p>
<br />
<p>On April 8th, 2012, 5:01 p.m., Kurt Hindenburg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Kurt Hindenburg.</div>
<p style="color: grey;"><i>Updated April 8, 2012, 5:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently 'unlimited scrollback' uses 3 files: data, line index, isWrapped. This patch removes the last two and keeps them in memory. Also the map() is no longer used - I don't think it was actually ever called in practice.
Currently I have a #define for the new code. The default is still the old code.
Perhaps I should use HistoryScrollFile2 instead of the #defines
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/History.h <span style="color: grey">(1a00a56)</span></li>
<li>src/History.cpp <span style="color: grey">(6aefd51)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104512/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>