<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104452/">http://git.reviewboard.kde.org/r/104452/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 1st, 2012, 4:07 p.m., <b>Jekyll Wu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, the resizing and text moving down in the HistorySizeDialog is a bit annoying.
As for the waning message, I think there are two minor problems:
1). "may be". That is not clear and will likely make users wonder: when is "may" and when is "may not" ? Since the current behavior is the scrollback data is always written into disk file when using unlimited scrollback, let's descibe the behavior as it is.
2). "stored on the hard disk". That "store" might be misleading, because "store" often implies a permanent and stable file within the directory tree which can be easily accessed after closing Konsole. Users might get the wrong idea what Konsole save scrollback data onto disk file in a permenant way without their explicit operation.
Suggested message:
"When using this option, the scrollback data are written unencrypted into temporary files. Those temporary files are deleted automatically when quitting Konsole."
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How about:
_ui->unlimitedWarningWidget->setText(i18nc("@info:status",
"When using this option, the scrollback data will be written "
"unencrypted to temporary files. Those temporary files will be "
"deleted automatically when quitting Konsole."));
On another note I think the HistorySizeDialog needs to be moved over to a .ui file.</pre>
<br />
<p>- Kurt</p>
<br />
<p>On April 1st, 2012, 2:49 p.m., Kurt Hindenburg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Kurt Hindenburg.</div>
<p style="color: grey;"><i>Updated April 1, 2012, 2:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some people may not realize that when using 'unlimited scrollback' the scrollback is on the hard drive unencrypted. The recent libvte 'security' report brought this issue up.
The warning is pretty bare-bone now. I wasn't sure if it should have more style to make it stand out more.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/HistorySizeWidget.cpp <span style="color: grey">(fcb131c)</span></li>
<li>src/HistorySizeWidget.ui <span style="color: grey">(abba938)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104452/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>