<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104361/">http://git.reviewboard.kde.org/r/104361/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hard to say. On the one hand, I think it's bad design to put it in that context menu, because managing profiles is not part of the context of an individual terminal. And as you say, it doesn't matter to Yakuake since it has a global action (in fact, it was me who asked Robert to make the slot available for that purpose, years ago). OTOH, it's true that it would probably help other KPart-using apps unaware of the slot.
I guess I won't really object if you add it, but it's definitely a hack.</pre>
<br />
<p>- Eike</p>
<br />
<p>On March 22nd, 2012, 7:23 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole, Yakuake and Eike Hein.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated March 22, 2012, 7:23 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That entry was there in the early versions of KDE 4.x(like 4.1), but was gone since KDE 4.7 or even earlier.
The rationale for getting it back :
* "Switch Profile" only lists profiles set as "Favorite" or "Show in menu"
* each konsolepart has its own sets of favorites, instead of reusing the sets from stand-alone Konsole
* The only way to change favorite status is using the "Manage Profiles" dialog
* konsolepart provide a slot "showManageProfilesDialog(QWidget* parent)" for show that dialog, but most hosting applications do not take advantage of it and provide an GUI item. Yakuake, Konversation and QuadKonsole4 seem to be the exceptions.
* so there is no way for user to change favorite status, and "Switch Profile" always contains one item: "Default Profile". Apparently, it is confusing.
Personally I don't want to add it into the context menu, because it is really a global instead of context related action. But currently konsolepart only has a context menu, so put it there for now.
If the consensus is NOT getting it back, then it is better to remove those related code.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktop/partui.rc <span style="color: grey">(2eacc48)</span></li>
<li>src/Part.h <span style="color: grey">(31fff53)</span></li>
<li>src/Part.cpp <span style="color: grey">(7bce172)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104361/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104361/s/485/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/22/before_400x100.png" style="border: 1px black solid;" alt="before" /></a>
<a href="http://git.reviewboard.kde.org/r/104361/s/486/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/22/after_400x100.png" style="border: 1px black solid;" alt="after" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>