<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104425/">http://git.reviewboard.kde.org/r/104425/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 193777e21a2f813fe273abaae03961a37eb900d9 by Jekyll Wu to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 27th, 2012, 11:55 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated March 27, 2012, 11:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The existing class SessionManager actually manages both profiles and sessions. Although sessions and profiles are closed related in concept, their corresponding code within existing SessionManager are mostly independent upon each other. Also, code like "SessionManager::instance()->defaultProfile()" is confusing at first sight.
The patch splits SessionManager into ProfileManager and SessionManager, each doing the job as its name implies.
Unlike previous split, this one involved new and more classes. I think it is better to be reviewd first.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with konsoleprofile, 'konsole --profile', etc. No regression observed so far.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Application.cpp <span style="color: grey">(4925fa7)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(d53fd4c)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(58c6c21)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(e7da18e)</span></li>
<li>src/ManageProfilesDialog.cpp <span style="color: grey">(0c5e083)</span></li>
<li>src/Part.cpp <span style="color: grey">(3051ab7)</span></li>
<li>src/ProfileList.cpp <span style="color: grey">(bc95f49)</span></li>
<li>src/ProfileManager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ProfileManager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/SessionManager.h <span style="color: grey">(fe519dc)</span></li>
<li>src/SessionManager.cpp <span style="color: grey">(bc9988f)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(52b62c0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104425/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>